Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OICD Keep also local login #1029

Open
matteovisotto opened this issue Feb 12, 2025 · 2 comments
Open

OICD Keep also local login #1029

matteovisotto opened this issue Feb 12, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@matteovisotto
Copy link

Is this a feature for the backend or frontend?

Frontend, Backend

What would you like?

Hi,
It would be great is SSO users and local user could use both auth methods. I mean, If I create a user using SSO then I also would like to set a password to login locally if the IdP is offline. On the other hand a user created locally with a password should also authenticate via SSO if the email match.

Why is this needed?

Better authentication

Other information

No response

@meltyshev
Copy link
Member

Hi! I’ve thought about this too but haven’t figured out the best way to handle it. Currently, the handshake with the OIDC provider is performed only at application startup, and if the provider doesn’t respond, the default login form appears. However, this doesn’t seem like the right approach since the provider can become unavailable at any time. I’ll try to come up with a solution, or maybe someone else has some ideas.

@meltyshev meltyshev added the enhancement New feature or request label Feb 13, 2025
@matteovisotto
Copy link
Author

In my configuration the login form appears with the SSO button to login with the IdP. The problem is the follow:
I create a local user with email and password. When I login using the IdP (which returns the same email address) the user property is_sso in the database is set to true, loosing the local login.
It should just authenticate the user without updating the database record, keeping the local account, but accessing also with the IdP.
In the same way, a user created via IdP should be able to set a password to login locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants