You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
QUnit's new assert.async() framework adds a breaking change in that resolving the async point (i.e., calling the callback returned by assert.async()) must be done after all assertions.
It is impossible in general to determine what the "last execution point" of a function should be, given the many potential callback scenarios that could arise. However, we could assume that the developers know what they are doing in terms of which block an async resolution call should go in, even if they may choose to resolve the async call at the beginning or in the middle of the block. Therefore we could move the async resolution call to the end of the block in which it appears, and that would take care of the vast majority of these problems.
Anything not solved by this approach is probably intractable or pathological and therefore not something qunit2-migrator should even bother dealing with. :-)
The text was updated successfully, but these errors were encountered:
QUnit's new
assert.async()
framework adds a breaking change in that resolving the async point (i.e., calling the callback returned byassert.async()
) must be done after all assertions.It is impossible in general to determine what the "last execution point" of a function should be, given the many potential callback scenarios that could arise. However, we could assume that the developers know what they are doing in terms of which block an async resolution call should go in, even if they may choose to resolve the async call at the beginning or in the middle of the block. Therefore we could move the async resolution call to the end of the block in which it appears, and that would take care of the vast majority of these problems.
Anything not solved by this approach is probably intractable or pathological and therefore not something qunit2-migrator should even bother dealing with. :-)
The text was updated successfully, but these errors were encountered: