pytest tests in core

[gforcada]

The current status is that the following Python distributions are using pytest tests and are in core:

• plone.classicui
• plone.distribution
• plone.exportimport
• plone.volto
• Products.CMFPlacefulWorkflow

That on its own is not good or bad, the problem lies on that these Python distributions are part of Plone core and thus are expected to be tested with the regular Jenkins jobs that ensure no breakages happen across Python distributions (i.e. a change in plone.app.event breaking plone.exportimport).

This is unfortunately not possible if zope.testrunner and pytest tests are mixed.

Possible solutions

• rewrite the tests in those few distributions to zope.testrunner
• rewrite ALL other Plone Python distributions to pytest 😅
• have another separate Jenkins job that ensures those Python distributions tests work with buildout.coredev latest changes

First and second are no fun. Second is more future proof, as we might want to switch eventually to pytest, but it will not happen overnight.

So third looks like the best middle ground, and actually sets the foundation for the 2nd option to happen.

The PR jenkins jobs will be a bit more complicated, as all tests are meant to run within that job.

Opinions?!

[gforcada]

On a buildout.coredev checkout:

make install
.venv/bin/pytest src/plone.volto/tests

Seems to work, I'm not 100% sure that this is using, say the src/Products.CMFPlone git checkout though... I have to go get my kids, I will keep looking at it.