Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor template list handling #87

Closed
ericof opened this issue Mar 26, 2025 · 0 comments · Fixed by #88
Closed

Refactor template list handling #87

ericof opened this issue Mar 26, 2025 · 0 comments · Fixed by #88
Assignees
@ericof
Labels
04 type: enhancement making existing stuff better

Comments

@ericof
Copy link
Member

ericof commented Mar 26, 2025

Cookieplone relies on the templates object available at the cookiecutter.json file on the top level of cookieplone-templates to list the available templates.

Even though every template entry under templates has a path property, cookieplone does not use this setting for anything.

It would be interesting to use that information, allowing a better organization of templates inside the cookieplone-templates.
@ericof ericof added the 04 type: enhancement making existing stuff better label Mar 26, 2025
@ericof ericof self-assigned this Mar 26, 2025
@ericof ericof moved this to Planned in Bucharest Sprint 2025 Mar 26, 2025
@ericof ericof moved this from Planned to In Progress in Bucharest Sprint 2025 Mar 26, 2025
ericof added a commit that referenced this issue Mar 26, 2025
@ericof
Refactor template list handling to use the template path information …
3a6f241 
…available at cookiecutter.json (Fixes #87)
@ericof ericof mentioned this issue Mar 26, 2025
Merged
ericof added a commit that referenced this issue Mar 27, 2025
@ericof @davisagli
Refactor template list handling (#88)
b55c0b7 
* Refactor template list handling to use the template path information available at cookiecutter.json (Fixes #87)

* Update cookieplone/repository.py

Co-authored-by: David Glick <[email protected]>

---------

Co-authored-by: David Glick <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Done in Bucharest Sprint 2025 Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericof ericof

Labels
04 type: enhancement making existing stuff better
Projects
Bucharest Sprint 2025
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor template list handling plone/cookieplone
1 participant
@ericof