Skip to content

Commit 105295a

Browse files
committed
Fix responsive dcc.Graph infinite scaling
1 parent 89a08e7 commit 105295a

File tree

1 file changed

+1
-23
lines changed

1 file changed

+1
-23
lines changed

components/dash-core-components/src/fragments/Graph.react.js

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -457,27 +457,6 @@ class PlotlyGraph extends Component {
457457
});
458458
}
459459

460-
getStyle() {
461-
const {responsive} = this.props;
462-
let {style} = this.props;
463-
464-
// When there is no forced responsive style, return the original style property
465-
if (!responsive) {
466-
return style;
467-
}
468-
469-
// Otherwise, if the height is not set, we make the graph size equal to the parent one
470-
if (!style) {
471-
style = {};
472-
}
473-
474-
if (!style.height) {
475-
return Object.assign({height: '100%'}, style);
476-
}
477-
478-
return style;
479-
}
480-
481460
componentDidMount() {
482461
const p = this.plot(this.props);
483462
this._queue = this.amendTraces(p, {}, this.props);
@@ -536,8 +515,7 @@ class PlotlyGraph extends Component {
536515
}
537516

538517
render() {
539-
const {className, id, loading_state} = this.props;
540-
const style = this.getStyle();
518+
const {className, id, loading_state, style} = this.props;
541519

542520
if (window.dash_component_api) {
543521
return (

0 commit comments

Comments
 (0)