fixing minor linting issues

Author: BSd3v

dash/backend/fastapi.py

@@ -7,11 +7,12 @@
 import importlib.util
 import time
 import traceback
+import re
 
 try:
     import uvicorn
     from fastapi import FastAPI, Request, Response
-    from fastapi.responses import JSONResponse, PlainTextResponse
+    from fastapi.responses import JSONResponse
     from fastapi.staticfiles import StaticFiles
     from starlette.responses import Response as StarletteResponse
     from starlette.datastructures import MutableHeaders
@@ -23,28 +24,24 @@
     Request = None
     Response = None
     JSONResponse = None
-    PlainTextResponse = None
     StaticFiles = None
     StarletteResponse = None
     MutableHeaders = None
     create_model = None
     Any = None
     Optional = None
 
+
+import json
+import os
 from dash.fingerprint import check_fingerprint
 from dash import _validate
 from dash.exceptions import (
     PreventUpdate,
-    InvalidResourceError,
-    InvalidCallbackReturnValue,
-    BackgroundCallbackError,
 )
 from dash.backend import set_request_adapter
 from .base_server import BaseDashServer
 
-import json
-import os
-
 CONFIG_PATH = "dash_config.json"
 
 
@@ -93,10 +90,8 @@ def register_assets_blueprint(
 
     def register_error_handlers(self, app):
         self.error_handling_mode = "prune"
-        # FastAPI uses exception handlers, but we will handle errors in middleware
-        pass
 
-    def _get_traceback(self, secret, error: Exception):
+    def _get_traceback(self, _secret, error: Exception):
         tb = error.__traceback__
         errors = traceback.format_exception(type(error), error, tb)
         pass_errs = []
@@ -113,15 +108,13 @@ def _get_traceback(self, secret, error: Exception):
         error_msg = str(error)
 
         # Parse traceback lines to group by file
-        import re
-
         file_cards = []
         pattern = re.compile(r'  File "(.+)", line (\d+), in (\w+)')
         lines = formatted_tb.split("\n")
         current_file = None
         card_lines = []
 
-        for i, line in enumerate(lines[:-1]):  # Skip the last line (error message)
+        for line in lines[:-1]:  # Skip the last line (error message)
             match = pattern.match(line)
             if match:
                 if current_file and card_lines:
@@ -274,7 +267,9 @@ def run(self, dash_app, app, host, port, debug, **kwargs):
         frame = inspect.stack()[2]
         config = dict(
             {"debug": debug} if debug else {},
-            **{f"dev_tools_{k}": v for k, v in dash_app._dev_tools.items()},
+            **{
+                f"dev_tools_{k}": v for k, v in dash_app._dev_tools.items()
+            },  # pylint: disable=protected-access
         )
         save_config(config)
         if debug:
@@ -307,7 +302,7 @@ def jsonify(self, obj):
     def get_request_adapter(self):
         return FastAPIRequestAdapter
 
-    def _make_before_middleware(self, func):
+    def _make_before_middleware(self, _func):
         async def middleware(request, call_next):
             try:
                 response = await call_next(request)

dash/backend/flask.py

@@ -5,13 +5,14 @@
 import mimetypes
 import time
 import inspect
+import traceback
 import flask
 from dash.fingerprint import check_fingerprint
 from dash import _validate
+from dash._callback import _invoke_callback, _async_invoke_callback
 from dash.exceptions import PreventUpdate, InvalidResourceError
 from dash.backend import set_request_adapter
 from .base_server import BaseDashServer
-import traceback
 
 
 class FlaskDashServer(BaseDashServer):
@@ -47,13 +48,13 @@ def _invalid_resources_handler(err):
 
     def _get_traceback(self, secret, error: Exception):
         try:
-            from werkzeug.debug import tbtools
+            from werkzeug.debug import (
+                tbtools,
+            )  # pylint: disable=import-outside-toplevel
         except ImportError:
             tbtools = None
 
         def _get_skip(error):
-            from dash._callback import _invoke_callback, _async_invoke_callback
-
             tb = error.__traceback__
             skip = 1
             while tb.tb_next is not None:
@@ -67,8 +68,6 @@ def _get_skip(error):
             return skip
 
         def _do_skip(error):
-            from dash._callback import _invoke_callback, _async_invoke_callback
-
             tb = error.__traceback__
             while tb.tb_next is not None:
                 if tb.tb_frame.f_code in [

dash/backend/quart.py

@@ -5,6 +5,7 @@
 import time
 from contextvars import copy_context
 import traceback
+import re
 
 try:
     import quart
@@ -56,7 +57,7 @@ def register_assets_blueprint(
         )
         app.register_blueprint(bp)
 
-    def _get_traceback(self, secret, error: Exception):
+    def _get_traceback(self, _secret, error: Exception):
         tb = error.__traceback__
         errors = traceback.format_exception(type(error), error, tb)
         pass_errs = []
@@ -73,15 +74,13 @@ def _get_traceback(self, secret, error: Exception):
         error_msg = str(error)
 
         # Parse traceback lines to group by file
-        import re
-
         file_cards = []
         pattern = re.compile(r'  File "(.+)", line (\d+), in (\w+)')
         lines = formatted_tb.split("\n")
         current_file = None
         card_lines = []
 
-        for i, line in enumerate(lines[:-1]):  # Skip the last line (error message)
+        for line in lines[:-1]:  # Skip the last line (error message)
             match = pattern.match(line)
             if match:
                 if current_file and card_lines:

dash/dash.py

@@ -14,7 +14,6 @@
 import mimetypes
 import hashlib
 import base64
-import traceback
 from urllib.parse import urlparse
 from typing import Any, Callable, Dict, Optional, Union, Sequence, Literal, List