Skip to content

Commit 5f76332

Browse files
committed
Fix test
1 parent 95f098f commit 5f76332

File tree

3 files changed

+4
-10
lines changed

3 files changed

+4
-10
lines changed

components/dash-core-components/src/fragments/DatePickerRange.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,7 @@ const DatePickerRange = ({
333333
id={start_date_id || accessibleId}
334334
inputClassName="dash-datepicker-input dash-datepicker-start-date"
335335
value={startInputValue}
336-
onChange={e => setStartInputValue(e.target.value)}
336+
onChange={e => setStartInputValue(e.target?.value)}
337337
onKeyDown={handleStartInputKeyDown}
338338
onFocus={() => {
339339
if (isCalendarOpen) {
@@ -354,7 +354,7 @@ const DatePickerRange = ({
354354
id={end_date_id || accessibleId + '-end-date'}
355355
inputClassName="dash-datepicker-input dash-datepicker-end-date"
356356
value={endInputValue}
357-
onChange={e => setEndInputValue(e.target.value)}
357+
onChange={e => setEndInputValue(e.target?.value)}
358358
onKeyDown={handleEndInputKeyDown}
359359
onFocus={() => {
360360
if (isCalendarOpen) {

components/dash-core-components/src/fragments/DatePickerSingle.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ const DatePickerSingle = ({
177177
id={accessibleId}
178178
inputClassName="dash-datepicker-input dash-datepicker-end-date"
179179
value={inputValue}
180-
onChange={e => setInputValue(e.target.value)}
180+
onChange={e => setInputValue(e.target?.value)}
181181
onKeyDown={handleInputKeyDown}
182182
placeholder={placeholder}
183183
disabled={disabled}

components/dash-core-components/tests/integration/misc/test_popover_visibility.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ def test_mspv001_popover_visibility_when_app_is_smaller_than_popup(dash_dcc):
5656
)
5757

5858
dash_dcc.start_server(app, debug=True, use_reloader=False)
59+
dash_dcc.driver.set_window_size(1280, 1024)
5960

6061
# Wait for the page to load
6162
dash_dcc.wait_for_element("#dps")
@@ -74,8 +75,6 @@ def test_mspv001_popover_visibility_when_app_is_smaller_than_popup(dash_dcc):
7475
# Test DatePickerRange - click everything to verify all elements are accessible
7576
click_everything_in_datepicker("#dpr", dash_dcc)
7677

77-
assert dash_dcc.get_logs() == []
78-
7978

8079
def test_mspv002_popover_visibility_when_app_is_scrolled_down(dash_dcc):
8180
"""
@@ -103,7 +102,6 @@ def test_mspv002_popover_visibility_when_app_is_scrolled_down(dash_dcc):
103102
dash_dcc.wait_for_element("#dps")
104103

105104
click_everything_in_datepicker("#dps", dash_dcc)
106-
assert dash_dcc.get_logs() == []
107105

108106

109107
def test_mspv003_popover_contained_within_dash_app(dash_dcc):
@@ -150,8 +148,6 @@ def test_mspv003_popover_contained_within_dash_app(dash_dcc):
150148
# Click everything in the datepicker to verify all elements are accessible
151149
click_everything_in_datepicker("#dpr", dash_dcc)
152150

153-
assert dash_dcc.get_logs() == []
154-
155151

156152
def test_mspv004_popover_inherits_container_styles(dash_dcc):
157153
"""Test that calendar days inherit font color and size from container.
@@ -193,5 +189,3 @@ def test_mspv004_popover_inherits_container_styles(dash_dcc):
193189

194190
# Font size should be 24px
195191
assert font_size == "24px", "Expected calendar day to inherit its font size"
196-
197-
assert dash_dcc.get_logs() == []

0 commit comments

Comments
 (0)