Code quality improvements

Author: timothyschoen

.clang-tidy

@@ -0,0 +1,147 @@
+# Generated from CLion Inspection settings
+---
+Checks: '-*,
+bugprone-argument-comment,
+bugprone-assert-side-effect,
+bugprone-bad-signal-to-kill-thread,
+bugprone-branch-clone,
+bugprone-copy-constructor-init,
+bugprone-dangling-handle,
+bugprone-dynamic-static-initializers,
+bugprone-fold-init-type,
+bugprone-forward-declaration-namespace,
+bugprone-forwarding-reference-overload,
+bugprone-inaccurate-erase,
+bugprone-incorrect-roundings,
+bugprone-integer-division,
+bugprone-lambda-function-name,
+bugprone-macro-parentheses,
+bugprone-macro-repeated-side-effects,
+bugprone-misplaced-operator-in-strlen-in-alloc,
+bugprone-misplaced-pointer-arithmetic-in-alloc,
+bugprone-misplaced-widening-cast,
+bugprone-move-forwarding-reference,
+bugprone-multiple-statement-macro,
+bugprone-no-escape,
+bugprone-not-null-terminated-result,
+bugprone-parent-virtual-call,
+bugprone-posix-return,
+bugprone-reserved-identifier,
+bugprone-sizeof-container,
+bugprone-sizeof-expression,
+bugprone-spuriously-wake-up-functions,
+bugprone-string-constructor,
+bugprone-string-integer-assignment,
+bugprone-string-literal-with-embedded-nul,
+bugprone-suspicious-enum-usage,
+bugprone-suspicious-include,
+bugprone-suspicious-memory-comparison,
+bugprone-suspicious-memset-usage,
+bugprone-suspicious-missing-comma,
+bugprone-suspicious-semicolon,
+bugprone-suspicious-string-compare,
+bugprone-swapped-arguments,
+bugprone-terminating-continue,
+bugprone-throw-keyword-missing,
+bugprone-too-small-loop-variable,
+bugprone-undefined-memory-manipulation,
+bugprone-undelegated-constructor,
+bugprone-unhandled-self-assignment,
+bugprone-unused-raii,
+bugprone-unused-return-value,
+bugprone-use-after-move,
+bugprone-virtual-near-miss,
+cert-dcl21-cpp,
+cert-dcl58-cpp,
+cert-err34-c,
+cert-err52-cpp,
+cert-err60-cpp,
+cert-flp30-c,
+cert-msc50-cpp,
+cert-msc51-cpp,
+cert-str34-c,
+cppcoreguidelines-interfaces-global-init,
+cppcoreguidelines-narrowing-conversions,
+cppcoreguidelines-pro-type-member-init,
+cppcoreguidelines-pro-type-static-cast-downcast,
+cppcoreguidelines-slicing,
+google-default-arguments,
+google-explicit-constructor,
+google-runtime-operator,
+hicpp-exception-baseclass,
+hicpp-multiway-paths-covered,
+misc-misplaced-const,
+misc-new-delete-overloads,
+misc-no-recursion,
+misc-non-copyable-objects,
+misc-throw-by-value-catch-by-reference,
+misc-unconventional-assign-operator,
+misc-uniqueptr-reset-release,
+modernize-avoid-bind,
+modernize-concat-nested-namespaces,
+modernize-deprecated-headers,
+modernize-deprecated-ios-base-aliases,
+modernize-loop-convert,
+modernize-make-shared,
+modernize-make-unique,
+modernize-pass-by-value,
+modernize-raw-string-literal,
+modernize-redundant-void-arg,
+modernize-replace-auto-ptr,
+modernize-replace-disallow-copy-and-assign-macro,
+modernize-replace-random-shuffle,
+modernize-return-braced-init-list,
+modernize-shrink-to-fit,
+modernize-unary-static-assert,
+modernize-use-auto,
+modernize-use-bool-literals,
+modernize-use-emplace,
+modernize-use-equals-default,
+modernize-use-equals-delete,
+modernize-use-nodiscard,
+modernize-use-noexcept,
+modernize-use-nullptr,
+modernize-use-override,
+modernize-use-transparent-functors,
+modernize-use-uncaught-exceptions,
+mpi-buffer-deref,
+mpi-type-mismatch,
+openmp-use-default-none,
+performance-faster-string-find,
+performance-for-range-copy,
+performance-implicit-conversion-in-loop,
+performance-inefficient-algorithm,
+performance-inefficient-string-concatenation,
+performance-inefficient-vector-operation,
+performance-move-const-arg,
+performance-move-constructor-init,
+performance-no-automatic-move,
+performance-noexcept-move-constructor,
+performance-trivially-destructible,
+performance-type-promotion-in-math-fn,
+performance-unnecessary-copy-initialization,
+performance-unnecessary-value-param,
+portability-simd-intrinsics,
+readability-avoid-const-params-in-decls,
+readability-const-return-type,
+readability-container-size-empty,
+readability-convert-member-functions-to-static,
+readability-delete-null-pointer,
+readability-deleted-default,
+readability-inconsistent-declaration-parameter-name,
+readability-make-member-function-const,
+readability-misleading-indentation,
+readability-misplaced-array-index,
+readability-non-const-parameter,
+readability-redundant-control-flow,
+readability-redundant-declaration,
+readability-redundant-function-ptr-dereference,
+readability-redundant-smartptr-get,
+readability-redundant-string-cstr,
+readability-redundant-string-init,
+readability-simplify-subscript-expr,
+readability-static-accessed-through-instance,
+readability-static-definition-in-anonymous-namespace,
+readability-string-compare,
+readability-uniqueptr-delete-release,
+readability-use-anyofallof'

Source/Box.cpp

@@ -428,7 +428,7 @@ void Box::updatePorts()
             edge->setTooltip(tooltip);
         }
 
-        // Dont show for graphs or presentation mode
+        // Don't show for graphs or presentation mode
         edge->setVisible(!(cnv->isGraph || cnv->presentationMode == var(true)));
         edge->repaint();
 

Source/Canvas.cpp

@@ -448,7 +448,7 @@ void Canvas::mouseUp(const MouseEvent& e)
         }
     }
 
-    // Releasing a connect by drag action
+    // Releasing a connect-by-drag action
     if (connectingWithDrag && connectingEdge)
     {
         if (nearestEdge)

Source/Connection.cpp

@@ -173,7 +173,7 @@ bool Connection::intersects(Rectangle<float> toCheck, int accuracy) const
     {
         auto point1 = Point<float>(i.x1, i.y1);
 
-        // Skip points to reduce accuracy a little bit for better performance
+        // Skip points to reduce accuracy a bit for better performance
         for (int n = 0; n < accuracy; n++)
         {
             auto next = i.next();

Source/Connection.h

@@ -77,7 +77,6 @@ class Connection : public Component, public ComponentListener
     PathPlan currentPlan;
 
     Value locked;
-    Value connectionStyle;
 
     Canvas* cnv;
 

Source/Dialogs/Deken.h

@@ -728,7 +728,7 @@ class Deken : public Component, public ListBoxModel, public ScrollBar::Listener,
         }
     };
 
-    bool checkArchitecture(String platform)
+    static bool checkArchitecture(String platform)
     {
         // Check OS
         if (platform.upToFirstOccurrenceOf("-", false, false) != os) return false;
@@ -743,8 +743,8 @@ class Deken : public Component, public ListBoxModel, public ScrollBar::Listener,
         return false;
     }
 
-    String floatsize = String(PD_FLOATSIZE);
-    String os =
+    static inline const String floatsize = String(PD_FLOATSIZE);
+    static inline const String os =
 #if JUCE_LINUX
         "Linux"
 #elif JUCE_MAC
@@ -766,7 +766,7 @@ class Deken : public Component, public ListBoxModel, public ScrollBar::Listener,
 #endif
         ;
 
-    StringArray machine =
+    static inline const StringArray machine =
 #if defined(__x86_64__) || defined(__amd64__) || defined(_M_X64) || defined(_M_AMD64)
         {"amd64", "x86_64"}
 #elif defined(__i386__) || defined(__i486__) || defined(__i586__) || defined(__i686__) || defined(_M_IX86)

Source/Dialogs/Dialogs.h

@@ -86,8 +86,6 @@ struct Dialog : public Component
 
 struct Dialogs
 {
-    Dialogs();
-
     static void showSaveDialog(Component* centre, String filename, std::function<void(int)> callback);
     static void showArrayDialog(Component* centre, std::function<void(int, String, String)> callback);
 

Source/Dialogs/SettingsDialog.h

@@ -12,7 +12,7 @@ struct ThemePanel : public Component, public Value::Listener
 
     OwnedArray<PropertiesPanel::Property> panels;
 
-    ThemePanel(ValueTree globalSettings) : settingsTree(globalSettings)
+    explicit ThemePanel(ValueTree globalSettings) : settingsTree(globalSettings)
     {
         fontValue.setValue(LookAndFeel::getDefaultLookAndFeel().getTypefaceForFont(Font())->getName());
         fontValue.addListener(this);

Source/Objects/ArrayObject.h

@@ -25,27 +25,27 @@ class PdArray
     PdArray() = default;
 
     // Gets the name of the array.
-    String getName() const noexcept
+    String getName() const 
     {
         return name;
     }
 
-    PdArray::DrawType getDrawType() const noexcept
+    PdArray::DrawType getDrawType() const 
     {
         libpd_set_instance(static_cast<t_pdinstance*>(instance));
         return static_cast<DrawType>(libpd_array_get_style(name.toRawUTF8()));
     }
 
     // Gets the scale of the array.
-    std::array<float, 2> getScale() const noexcept
+    std::array<float, 2> getScale() const 
     {
         float min = -1, max = 1;
         libpd_set_instance(static_cast<t_pdinstance*>(instance));
         libpd_array_get_scale(name.toRawUTF8(), &min, &max);
         return {min, max};
     }
 
-    void setScale(std::array<float, 2> scale) noexcept
+    void setScale(std::array<float, 2> scale) 
     {
         auto& [min, max] = scale;
         libpd_set_instance(static_cast<t_pdinstance*>(instance));
@@ -282,7 +282,7 @@ struct GraphicalArray : public Component
         }
     }
 
-    size_t getArraySize() const noexcept
+    size_t getArraySize() const 
     {
         return vec.size();
     }
@@ -470,7 +470,7 @@ struct ArrayObject final : public GUIObject
         g.drawRoundedRectangle(getLocalBounds().toFloat().reduced(0.5f), 2.0f, 1.0f);
     }
 
-    PdArray getArray() const noexcept
+    PdArray getArray() const 
     {
         return {libpd_array_get_name(static_cast<t_canvas*>(ptr)->gl_list), cnv->pd->m_instance};
     }

Source/Objects/AtomObject.h

@@ -76,9 +76,16 @@ struct AtomObject : public GUIObject
         auto* gatom = static_cast<t_fake_gatom*>(ptr);
         gatom->a_text.te_width = b.getWidth() / fontWidth;
     }
-
+    
     void resized() override
     {
+        int fontWidth = glist_fontwidth(cnv->patch.getPointer());
+        int width = jlimit(30, maxSize, (getWidth() / fontWidth) * fontWidth);
+        int height = jlimit(18, maxSize, getHeight());
+        if (getWidth() != width || getHeight() != height)
+        {
+            box->setSize(width + Box::doubleMargin, height + Box::doubleMargin);
+        }
     }
 
     int getAtomHeight() const
@@ -192,17 +199,17 @@ struct AtomObject : public GUIObject
         }
     }
 
-    float getFontHeight() const noexcept
+    float getFontHeight() const 
     {
         return static_cast<t_fake_gatom*>(ptr)->a_fontsize;
     }
 
-    void setFontHeight(float newSize) noexcept
+    void setFontHeight(float newSize) 
     {
         static_cast<t_fake_gatom*>(ptr)->a_fontsize = newSize;
     }
 
-    Rectangle<int> getLabelBounds() const noexcept
+    Rectangle<int> getLabelBounds() const 
     {
         auto objectBounds = box->getBounds().reduced(Box::margin);
         int fontHeight = getAtomHeight() - 6;
@@ -267,25 +274,25 @@ struct AtomObject : public GUIObject
         atom->a_label = gensym(newText.toRawUTF8());
     }
 
-    void setLabelPosition(int wherelabel) noexcept
+    void setLabelPosition(int wherelabel) 
     {
         auto* gatom = static_cast<t_fake_gatom*>(ptr);
         gatom->a_wherelabel = wherelabel - 1;
     }
 
-    String getSendSymbol() noexcept
+    String getSendSymbol() 
     {
         auto* atom = static_cast<t_fake_gatom*>(ptr);
         return String(atom->a_symfrom->s_name);
     }
 
-    String getReceiveSymbol() noexcept
+    String getReceiveSymbol() 
     {
         auto* atom = static_cast<t_fake_gatom*>(ptr);
         return String(atom->a_symto->s_name);
     }
 
-    void setSendSymbol(const String& symbol) const noexcept
+    void setSendSymbol(const String& symbol) const 
     {
         if (symbol.isEmpty()) return;
 
@@ -294,7 +301,7 @@ struct AtomObject : public GUIObject
         atom->a_expanded_to = canvas_realizedollar(atom->a_glist, atom->a_symto);
     }
 
-    void setReceiveSymbol(const String& symbol) const noexcept
+    void setReceiveSymbol(const String& symbol) const 
     {
         if (symbol.isEmpty()) return;
 
@@ -323,7 +330,7 @@ struct AtomObject : public GUIObject
     }
 
     /* undo previous operation: strip leading "-" if found.  This is used
-    both to restore send, etc, names when loading from a file, and to
+    both to restore send, etc., names when loading from a file, and to
     set them from the properties dialog.  In the former case, since before
     version 0.52 '$" was aliases to "#", we also bash any "#" characters
     to "$".  This is unnecessary when reading files saved from 0.52 or later,

Source/Objects/BangObject.h

@@ -126,7 +126,7 @@ struct BangObject final : public IEMObject
         }
     }
 
-    float getMaximum() const noexcept
+    float getMaximum() const 
     {
         return (static_cast<t_my_numbox*>(ptr))->x_max;
     }