Skip to content

remove workaround for v1/groups endpoint #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
toph-allen opened this issue Nov 8, 2024 · 1 comment · Fixed by #393
Closed

remove workaround for v1/groups endpoint #328

toph-allen opened this issue Nov 8, 2024 · 1 comment · Fixed by #393
Assignees
@nealrichardson

Comments

@toph-allen
Copy link
Collaborator

The get_groups() function has a workaround for a pagination quirk in Connect's v1/groups API, which always returns the first page of results when a prefix is specified.

This bug is tracked in the Connect repo: https://github.com/rstudio/connect/issues/28774

When that's resolved, we should remove the workaround: #326 (comment)
@toph-allen toph-allen self-assigned this Nov 8, 2024
@toph-allen toph-allen added the on hold things that are waiting for other things label Nov 8, 2024
@nealrichardson
Copy link
Collaborator

The groups API will support pagination in 2025.04.0, but we don't want to just revert #326 because we'll still need that for compatibility with older versions. So we'll want to do things differently based on the Connect server version.

This was referenced Apr 25, 2025
Merged
Merged
@tdstein tdstein assigned nealrichardson and unassigned toph-allen Apr 29, 2025
@nealrichardson nealrichardson removed the on hold things that are waiting for other things label Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nealrichardson nealrichardson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: update get_groups() to support pagination, if Connect version supports posit-dev/connectapi
2 participants
@nealrichardson @toph-allen