Add "test-core" target for quick and dirty local CI #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think having a set of core tests for iterating more quickly (there's just a lot of tests) is a good idea! Let me know when this is ready and I'll happily merge. |
Contributor
Author
|
Nice! This should be ready to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I've noticed the spark tests run very long (pass --durations 10 to pytest) and instead of refactoring the fixture scheme, I just added a
test-coretarget that removes spark, sqllite and parquet based tests. This is useful for very quickly running tests when you make smaller changes locally, it speeds up development cycles.2 Alternatives to this: 1) Refactoring pyspark fictures and 2) Don't test as much
I think 1) could be reasonable eventually but 2) is off limits for me, I like to run tests early and often, even if it's limited.
Let me know what you think :)