Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundled Quarto not found if not on PATH and using Pyenv #4511

Closed
Tracked by #4858
testlabauto opened this issue Aug 28, 2024 · 3 comments
Closed
Tracked by #4858

Bundled Quarto not found if not on PATH and using Pyenv #4511

testlabauto opened this issue Aug 28, 2024 · 3 comments
Assignees
Labels
area: quarto Issues related to Quarto category.

Comments

@testlabauto
Copy link
Contributor

testlabauto commented Aug 28, 2024

Need to handle quarto-dev/quarto#517 on the Positron side.

System details:

Positron and OS details:

2024.08.0-77
OSX

Interpreter details:

Any

Describe the issue:

See quarto-dev/quarto#517

Steps to reproduce the issue:

See quarto-dev/quarto#517

Expected or desired behavior:

Bundled Quarto can be used without a seperate Quarto install

Were there any error messages in the UI, Output panel, or Developer Tools console?

See quarto-dev/quarto#517

Once we have fixed

We will need to make changes to our Quarto tests. @testlabauto created a work around for this issue. Once we make this fixed we will need to change our Quarto tests to ensure they are working as expected.

@juliasilge juliasilge added the area: quarto Issues related to Quarto category. label Aug 28, 2024
@juliasilge juliasilge changed the title Bundled Quarto doesn't work without making some Quarto changes Bundled Quarto not found if not on PATH and using Pyenv Sep 3, 2024
@juliasilge juliasilge added this to the 2024.11.0 Pre-Release milestone Sep 3, 2024
@juliasilge
Copy link
Contributor

From @jmcphers:

pre-bundling Quarto (as was done in #3705) doesn't fix the problem of Positron working without an existing Quarto installation if you're using Pyenv, due to a bad interaction between Pyenv and the Quarto extension.

The actual change will probably need to happen in the Quarto extension and is tracked by quarto-dev/quarto#517.

@jlang-311
Copy link

@testlabauto created a work around for this issue. Once we make this fixed we will need to change our Quarto tests to ensure they are working as expected.

@isabelizimm isabelizimm self-assigned this Oct 22, 2024
isabelizimm added a commit that referenced this issue Nov 14, 2024
Related to #4511 

the Python extension is using a newer version of VSCode, with a
`GlobalEnvironmentVariableCollection` which overwrites other extension's
contributions to environment variables, such as PATH. This moves to
using `EnvironmentVariableCollection`, which will only touch its
extension contributions.

From what I understand, the original change was made to be able to set
multiple folder level scopes in a workspace, eg, set different
interpreters for different folders inside a workspace:
microsoft/vscode-python#20492 (comment)
and microsoft/vscode#171173
Positron operates (or at least the interpreter dropdown UI shows) 1
interpreter per workspace, so I don’t think the scoping stuff applies to
us.

### QA Notes

- make sure Quarto is in your local `positron` directory. AFAICT this
does not automatically populate on `yarn` runs, so you might have to put
it there manually. (At build time, it is at
`~/Applications/Positron.app/Contents/Resources/app/quarto/bin`, which
is being properly identified by the Quarto extension 👍)
- delete other local Quarto installations (likely by running `rm -fr
~/Applications/quarto`)
- open up Positron
- run `quarto --version` in terminal, should not give any errors

---------

Signed-off-by: Isabel Zimmerman <[email protected]>
@testlabauto
Copy link
Contributor Author

Verified Fixed

Positron Version(s) : 2024.12.0-41
OS Version          : OSX

Test scenario(s)

Verified by removing local quarto cli install. Note that the "workaround" mentioned in the comments needs to stay where it is because dev build do not have the bundled CLI.

Link(s) to TestRail test cases run or created:

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: quarto Issues related to Quarto category.
Projects
None yet
Development

No branches or pull requests

4 participants