Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup npm workspaces for shared code #1291

Open
dotNomad opened this issue Apr 3, 2024 · 2 comments
Open

Setup npm workspaces for shared code #1291

dotNomad opened this issue Apr 3, 2024 · 2 comments

Comments

@dotNomad
Copy link
Collaborator

dotNomad commented Apr 3, 2024

To share non-CommonJS code, like TypeScript code, we need bundling first so this is on hold until #1289 is complete.


NPM workspaces will allow us to import packages in the repo into other packages for very easy code re-use and isolation. This work spurred out of the sharing of the api module and it having issues between VSCode and the standalone-UI. Keeping those the same is a challenge that a monorepo setup with npm workspaces solves in addition to allowing to create as many shared modules as we need.

@dotNomad dotNomad added the hold label Apr 3, 2024
@dotNomad dotNomad linked a pull request Apr 3, 2024 that will close this issue
@dotNomad
Copy link
Collaborator Author

dotNomad commented Apr 3, 2024

sourcegraph is a good example of a monorepo with frontend and Go organization

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants