Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R Packages text when no renv.lock file exists #1747

Closed
kgartland-rstudio opened this issue May 29, 2024 · 4 comments
Closed

R Packages text when no renv.lock file exists #1747

kgartland-rstudio opened this issue May 29, 2024 · 4 comments
Labels

Comments

@kgartland-rstudio
Copy link
Collaborator

I think this was placeholder text when we didn't have a Scan button for the R Packages.

To deploy R content, you need a package file listing any package dependencies, but the file does not exist or is invalid. Use 'renv::snapshot()' at an R console to create one or edit the current configuration file (configuration-1) to point to an existing valid file.

Should we instead be asking the user to hit the Scan button here?

@kgartland-rstudio kgartland-rstudio added enhancement New feature or request vscode labels May 29, 2024
@mmarchetti
Copy link
Contributor

We should recommend clicking the big blue button, or running renv::snapshot() (or maybe renv::init()).

@mmarchetti
Copy link
Contributor

Also see #1745

@dotNomad dotNomad modified the milestones: v1.2.0, v1.1.7 Sep 18, 2024
@dotNomad dotNomad modified the milestones: v1.1.7, v1.2.0 Sep 30, 2024
@jonkeane
Copy link
Collaborator

jonkeane commented Oct 4, 2024

I'm bumping this out of the 1.2 release, but we should come back to it. Making sure we have a good experience for someone coming fresh and not familiar with renv is on us to make sure they have an easy onboarding (since we require they use it). Same for #1745

@jonkeane jonkeane removed this from the v1.2.0 milestone Oct 4, 2024
@dotNomad
Copy link
Collaborator

With the work that @marcosnav did on the no renv or renv.lock cases in #2560 the deploy prompts help a lot with renv.

The R Packages section still needs some work. It recommends looking at the renv documentation right now:

Image

However this issue is a bit stale - @marcosnav created a follow-up issue to provide the same helpful prompts we offer during deployment to the R Packages section #2565. I believe that issue captures the intention behind this one.

@dotNomad dotNomad closed this as not planned Won't fix, can't repro, duplicate, stale Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants