Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Files Treeview: nit: easy to exclude entrypoint file #2166

Closed
kgartland-rstudio opened this issue Aug 22, 2024 · 4 comments
Closed

Comments

@kgartland-rstudio
Copy link
Collaborator

Usability nit: the entrypoint can be deselected and deployed. It was harder to deselect it in the previous view because you had to hit the little icon, but now since I can just click anywhere in the filename, it's easier to accidentally add/remove a file.

@dotNomad
Copy link
Collaborator

Some of my thoughts:

We currently require the entrypoint to be in the files list. The entrypoint attribute isn't a special include case where the entrypoint file cannot be excluded even if the files list attribute in the configuration is empty.

This behavior makes me want to mirror it in the UI since we are code first, and the TOML code is informing the behavior.

We could require a confirmation, or some other behavior when unchecking the entrypoint. I worry about that a bit since that starts getting into the question of - what else do we require confirmation for. A requirements.txt could also fit into that list, or a renv.lock, but only if Python or R details are included in the configuration file.


I try to balance "this is part of the learning curve" and hand holding for complex UIs, and for this in particular I lean toward "this is part of the learning curve".

If we change the behavior of the files include array in the Configuration (to always include the entrypoint, or other files) then I would be more in favor of changing the behavior of the UI.

@dotNomad dotNomad added the api label Aug 27, 2024
@dotNomad
Copy link
Collaborator

To support disabling and auto-checking the entrypoint (and any other files like the requirements.txt) we need a built in inclusion from the files API.

@dotNomad
Copy link
Collaborator

Leaving this out of 1.2.0 until we get outside feedback.

@dotNomad
Copy link
Collaborator

dotNomad commented Jan 8, 2025

Closing this as a duplicate of #1493

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants