Skip to content

Commit 2efd90a

Browse files
committed
Update tests
1 parent d3353a1 commit 2efd90a

File tree

3 files changed

+17
-3
lines changed

3 files changed

+17
-3
lines changed

.gitignore

+3
Original file line numberDiff line numberDiff line change
@@ -25,3 +25,6 @@
2525
htmlcov
2626
test-home/
2727
venv
28+
29+
# Temporary dev files
30+
vetiver-testing/rsconnect_api_keys.json

rsconnect/api.py

+2
Original file line numberDiff line numberDiff line change
@@ -998,12 +998,14 @@ def runtime_caches(self):
998998
def delete_runtime_cache(self, language, version, image_name, dry_run):
999999
target = {"language": language, "version": version, "image_name": image_name, "dry_run": dry_run}
10001000
result = self.client.system_caches_runtime_delete(target)
1001+
self.state["result"] = result
10011002
if result["task_id"] is None:
10021003
print("Dry run finished")
10031004
else:
10041005
(log_lines, task_status) = self.client.wait_for_task(
10051006
result["task_id"], connect_logger.info, raise_on_error=False
10061007
)
1008+
self.state["task_status"] = task_status
10071009
return self
10081010

10091011

tests/test_api.py

+12-3
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,7 @@ def test_client_system_caches_runtime_list(self):
103103
result = ce.runtime_caches
104104
self.assertDictEqual(result, mocked_response)
105105

106+
# RSConnectExecutor.delete_runtime_cache() dry run returns expected request
106107
# RSConnectExecutor.delete_runtime_cache() dry run prints expected messages
107108
@httpretty.activate(verbose=True, allow_net_connect=False)
108109
def test_executor_delete_runtime_cache_dry_run(self):
@@ -119,13 +120,16 @@ def test_executor_delete_runtime_cache_dry_run(self):
119120

120121
captured_output = io.StringIO()
121122
sys.stdout = captured_output
122-
result = ce.delete_runtime_cache(language="Python", version="1.2.3", image_name="teapot", dry_run=True)
123+
ce.delete_runtime_cache(language="Python", version="1.2.3", image_name="teapot", dry_run=True)
123124
sys.stdout = sys.__stdout__
124125

125126
# Print expectations
126127
output_lines = captured_output.getvalue().splitlines()
127128
self.assertEqual(output_lines[0], "Dry run finished")
128129

130+
# Result expectations
131+
self.assertDictEqual(mocked_output, ce.state["result"])
132+
129133
# RSConnectExecutor.delete_runtime_cache() wet run returns expected request
130134
# RSConnectExecutor.delete_runtime_cache() wet run prints expected messages
131135
@httpretty.activate(verbose=True, allow_net_connect=False)
@@ -165,11 +169,16 @@ def test_executor_delete_runtime_cache_wet_run(self):
165169

166170
captured_output = io.StringIO()
167171
sys.stdout = captured_output
168-
result = ce.delete_runtime_cache(language="Python", version="1.2.3", image_name="teapot", dry_run=False)
172+
ce.delete_runtime_cache(language="Python", version="1.2.3", image_name="teapot", dry_run=False)
169173
sys.stdout = sys.__stdout__
170174

171175
# Print expectations
172-
# TODO: Figure out how to capture the output of `connect_logger` and make assertions.
176+
# TODO: *We* don't print anything here anymore. Unsure how to capture log messages from Connect.
177+
# output_lines = captured_output.getvalue().splitlines()
178+
# self.assertEqual(output_lines[0], "Cache deletion finished")
179+
180+
# Result expectations
181+
self.assertDictEqual(mocked_task_status, ce.state["task_status"])
173182

174183
# RSConnectExecutor.delete_runtime_cache() raises the correct error
175184
@httpretty.activate(verbose=True, allow_net_connect=False)

0 commit comments

Comments
 (0)