Skip to content

Commit

Permalink
chore(ci): remove rsconnect-jupyter test suite (#638)
Browse files Browse the repository at this point in the history
  • Loading branch information
nealrichardson authored Feb 19, 2025
1 parent 06b5216 commit acdbf28
Show file tree
Hide file tree
Showing 21 changed files with 13 additions and 1,063 deletions.
47 changes: 0 additions & 47 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -175,53 +175,6 @@ jobs:
pytest tests/test_main_system_caches.py
pytest -m 'vetiver'
test-jupyter:
runs-on: ubuntu-latest
env:
CONNECT_LICENSE: ${{ secrets.RSC_LICENSE }}
ADMIN_API_KEY: ${{ secrets.ADMIN_API_KEY }}
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- uses: extractions/setup-just@v2
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Build Containers
run: |
cd integration-testing
docker compose build client
docker compose build cypress
- name: Start Connect + rsconnect-jupyter
run: |
just integration-testing/up
- name: Run Cypress Tests
run: |
just integration-testing/up-cypress
# Videos are captured whether the suite fails or passes
- name: Save videos
uses: actions/upload-artifact@v4
if: success() || failure()
with:
name: cypress-videos
path: integration-testing/cypress/videos
if-no-files-found: ignore
retention-days: 1

# Screenshots are only captured on failure
- name: Save screenshots
uses: actions/upload-artifact@v4
if: failure()
with:
name: cypress-screenshots
path: integration-testing/cypress/screenshots
if-no-files-found: ignore
retention-days: 1

test-connect:
needs: distributions
runs-on: ubuntu-latest
Expand Down
12 changes: 6 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
# The rsconnect-python CLI

This package provides a CLI (command-line interface) for interacting
with and deploying to Posit Connect. This is also used by the
[`rsconnect-jupyter`](https://github.com/rstudio/rsconnect-jupyter) package to deploy
Jupyter notebooks via the Jupyter web console. Many types of content supported by Posit
with and deploying to Posit Connect. Many types of content supported by Posit
Connect may be deployed by this package, including WSGI-style APIs, Dash, Streamlit,
Gradio, and Bokeh applications.

Expand Down Expand Up @@ -649,7 +647,7 @@ Generated from <code>rsconnect-python {{ rsconnect_python.version }}</code>

### Hide Jupyter Notebook Input Code Cells

The user can render a Jupyter notebook without its corresponding input code cells by passing the '--hide-all-input' flag through the cli:
You can render a Jupyter notebook without its corresponding input code cells by passing the '--hide-all-input' flag through the cli:

```bash
rsconnect deploy notebook \
Expand All @@ -659,7 +657,8 @@ rsconnect deploy notebook \
my-notebook.ipynb
```

To selectively hide input cells in a Jupyter notebook, the user needs to follow a two step process:
To selectively hide input cells in a Jupyter notebook, you need to do two things:

1. tag cells with the 'hide_input' tag,
2. then pass the ' --hide-tagged-input' flag through the cli:

Expand All @@ -671,7 +670,8 @@ rsconnect deploy notebook \
my-notebook.ipynb
```

By default, rsconnect-python does not install Jupyter notebook related depenencies. These dependencies are installed via rsconnect-jupyter. When the user is using the hide input features in rsconnect-python by itself without rsconnect-jupyter, he/she needs to install the following package depenecies:
By default, rsconnect-python does not install Jupyter notebook-related depenencies.
To use these hide input features in rsconnect-python you need to install these extra dependencies:

```
notebook
Expand Down
19 changes: 0 additions & 19 deletions integration-testing/content/notebook/README.md

This file was deleted.

Binary file not shown.
3 changes: 0 additions & 3 deletions integration-testing/content/notebook/requirements.txt

This file was deleted.

464 changes: 0 additions & 464 deletions integration-testing/content/notebook/stock-report-jupyter.ipynb

This file was deleted.

Binary file removed integration-testing/content/notebook/thumbnail.jpg
Binary file not shown.
119 changes: 0 additions & 119 deletions integration-testing/content/voila/index.ipynb

This file was deleted.

4 changes: 0 additions & 4 deletions integration-testing/content/voila/requirements.txt

This file was deleted.

22 changes: 0 additions & 22 deletions integration-testing/cypress.config.js

This file was deleted.

54 changes: 0 additions & 54 deletions integration-testing/cypress/e2e/jupyter.cy.js

This file was deleted.

44 changes: 0 additions & 44 deletions integration-testing/cypress/e2e/voila.cy.js

This file was deleted.

17 changes: 0 additions & 17 deletions integration-testing/cypress/plugins/index.js

This file was deleted.

Loading

0 comments on commit acdbf28

Please sign in to comment.