Skip to content

Commit bdf5d3e

Browse files
committed
stop testing 3.5 and 3.6
1 parent 68497f3 commit bdf5d3e

File tree

3 files changed

+6
-14
lines changed

3 files changed

+6
-14
lines changed

.github/workflows/main.yml

+3-5
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
matrix:
1515
# TODO: work on windows-latest compatibility?
1616
os: [ubuntu-latest]
17-
python-version: ['3.5', '3.6', '3.7', '3.8', '3.9', '3.10']
17+
python-version: ['3.7', '3.8', '3.9', '3.10']
1818
include:
1919
- os: macos-latest
2020
python-version: '3.9'
@@ -28,10 +28,8 @@ jobs:
2828
python-version: ${{ matrix.python-version }}
2929
- run: pip install -r requirements.txt
3030
- run: pip freeze
31-
- if: matrix.python-version > '3.5'
32-
run: make fmt
33-
- if: matrix.python-version >= '3.6'
34-
run: make lint
31+
- run: make fmt
32+
- run: make lint
3533
- run: python setup.py --version
3634
- run: make test-${{ matrix.python-version }}
3735
prerelease-test:

CONTRIBUTING.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ tooling](https://packaging.python.org/guides/tool-recommendations/).
55

66
To get started, you'll want to:
77
- clone the repo into a project directory
8-
- setup a virtual 3.5+ python environment in the project directory
8+
- setup a virtual 3.7+ python environment in the project directory
99
- activate that virtual environment
1010
- install the dependencies
1111
- validate your build environment with some sample commands

Makefile

+2-8
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,10 @@ SOURCE_DATE_EPOCH := $(shell date +%s)
3535
export SOURCE_DATE_EPOCH
3636

3737
.PHONY: all-tests
38-
all-tests: all-images test-3.5 test-3.6 test-3.7 test-3.8 test-3.9 test-3.10
38+
all-tests: all-images test-3.7 test-3.8 test-3.9 test-3.10
3939

4040
.PHONY: all-images
41-
all-images: image-3.5 image-3.6 image-3.7 image-3.8 image-3.9 image-3.10
41+
all-images: image-3.7 image-3.8 image-3.9 image-3.10
4242

4343
image-%:
4444
docker build -t rsconnect-python:$* --build-arg BASE_IMAGE=python:$*-slim .
@@ -62,9 +62,6 @@ mock-test-%: clean-stores
6262
fmt-%:
6363
$(RUNNER) 'black .'
6464

65-
.PHONY: fmt-3.5
66-
fmt-3.5: .fmt-unsupported
67-
6865
.PHONY: .fmt-unsupported
6966
.fmt-unsupported:
7067
@echo ERROR: This python version cannot run the fmting tools
@@ -83,9 +80,6 @@ lint-%:
8380
$(RUNNER) 'flake8 tests/'
8481
$(RUNNER) 'mypy -p rsconnect'
8582

86-
.PHONY: lint-3.5
87-
lint-3.5: .lint-unsupported
88-
8983
.PHONY: .lint-unsupported
9084
.lint-unsupported:
9185
@echo ERROR: This python version cannot run the linting tools

0 commit comments

Comments
 (0)