chore: remove pgexplain tips

Author: agneum

Dockerfile

@@ -5,7 +5,6 @@ RUN apk add --no-cache bash postgresql-client
 WORKDIR /home/
 
 COPY ./bin/joe ./bin/joe
-COPY ./configs/explain ./explain
 
 EXPOSE $SERVER_PORT
 

Dockerfile.ee

@@ -5,7 +5,6 @@ RUN apk add --no-cache bash postgresql-client
 WORKDIR /home/
 
 COPY ./bin/joe-ee ./bin/joe
-COPY ./configs/explain ./explain
 
 EXPOSE $SERVER_PORT
 

cmd/joe/main.go

@@ -103,14 +103,6 @@ func loadAppConfig() (*config.Config, error) {
 
 	botCfg.Enterprise = enterpriseOptions
 
-	// Load and validate an explain configuration file.
-	explainConfig, err := config.LoadExplainConfig()
-	if err != nil {
-		return nil, errors.Wrap(err, "failed to load an explain config")
-	}
-
-	botCfg.Explain = explainConfig
-
 	return &botCfg, nil
 }
 

configs/explain/explain.yaml

@@ -43,7 +43,7 @@ const (
 
 // Explain runs an explain query.
 func Explain(ctx context.Context, msgSvc connection.Messenger, command *platform.Command, msg *models.Message,
-	explainConfig pgexplain.ExplainConfig, session usermanager.UserSession) error {
+	session usermanager.UserSession) error {
 	if command.Query == "" {
 		return errors.New(MsgExplainOptionReq)
 	}
@@ -100,7 +100,7 @@ func Explain(ctx context.Context, msgSvc connection.Messenger, command *platform
 	command.PlanExecJSON = explainAnalyze
 
 	// Visualization.
-	explain, err := pgexplain.NewExplain(explainAnalyze, explainConfig)
+	explain, err := pgexplain.NewExplain(explainAnalyze)
 	if err != nil {
 		log.Err("Explain parsing: ", err)
 
@@ -156,32 +156,6 @@ func Explain(ctx context.Context, msgSvc connection.Messenger, command *platform
 		return err
 	}
 
-	// Recommendations.
-	tips, err := explain.GetTips()
-	if err != nil {
-		log.Err("Recommendations: ", err)
-		return err
-	}
-
-	recommends := ""
-	if len(tips) == 0 {
-		recommends += ":white_check_mark: Looks good"
-	} else {
-		for _, tip := range tips {
-			recommends += fmt.Sprintf(
-				":exclamation: %s – %s <%s|Show details>\n", tip.Name,
-				tip.Description, tip.DetailsUrl)
-		}
-	}
-
-	command.Recommendations = recommends
-
-	msg.AppendText("*Recommendations:*\n" + recommends)
-	if err = msgSvc.UpdateText(msg); err != nil {
-		log.Err("Show recommendations: ", err)
-		return err
-	}
-
 	// Summary.
 	stats := explain.RenderStats()
 	command.Stats = stats

pkg/bot/command/explain.go

@@ -9,7 +9,6 @@ import (
 	"time"
 
 	"gitlab.com/postgres-ai/joe/features/definition"
-	"gitlab.com/postgres-ai/joe/pkg/pgexplain"
 )
 
 const (
@@ -32,7 +31,6 @@ type Config struct {
 	Platform       Platform                     `yaml:"platform"`
 	Registration   Registration                 `yaml:"registration"`
 	ChannelMapping *ChannelMapping              `yaml:"channelMapping"`
-	Explain        pgexplain.ExplainConfig      `yaml:"-"`
 	Enterprise     definition.EnterpriseOptions `yaml:"-"`
 }
 

pkg/config/config.go

@@ -124,7 +124,6 @@ func (a *Assistant) buildMessageProcessor(channelID string, dbLabInstance *dblab
 	processingCfg := msgproc.ProcessingConfig{
 		App:      a.appCfg.App,
 		Platform: a.appCfg.Platform,
-		Explain:  a.appCfg.Explain,
 		DBLab:    dbLabInstance.Config(),
 		EntOpts:  a.appCfg.Enterprise,
 		Project:  a.appCfg.Platform.Project,

pkg/config/pgexplain.go

@@ -125,7 +125,6 @@ func (a *Assistant) buildMessageProcessor(channelID string, dbLabInstance *dblab
 	processingCfg := msgproc.ProcessingConfig{
 		App:      a.appCfg.App,
 		Platform: a.appCfg.Platform,
-		Explain:  a.appCfg.Explain,
 		DBLab:    dbLabInstance.Config(),
 		EntOpts:  a.appCfg.Enterprise,
 		Project:  a.appCfg.Platform.Project,

pkg/connection/slack/assistant.go

@@ -142,7 +142,6 @@ func (a *Assistant) buildMessageProcessor(channelID string, dbLabInstance *dblab
 	processingCfg := msgproc.ProcessingConfig{
 		App:      a.appCfg.App,
 		Platform: a.appCfg.Platform,
-		Explain:  a.appCfg.Explain,
 		DBLab:    dbLabInstance.Config(),
 		EntOpts:  a.appCfg.Enterprise,
 		Project:  a.appCfg.Platform.Project,

pkg/connection/slackrtm/assistant.go

@@ -151,7 +151,6 @@ func (a *Assistant) buildMessageProcessor(channelID string, dbLabInstance *dblab
 	processingCfg := msgproc.ProcessingConfig{
 		App:      a.appCfg.App,
 		Platform: a.appCfg.Platform,
-		Explain:  a.appCfg.Explain,
 		DBLab:    dbLabInstance.Config(),
 		EntOpts:  a.appCfg.Enterprise,
 		Project:  a.appCfg.Platform.Project,
@@ -247,7 +246,7 @@ func (a *Assistant) verificationHandler(w http.ResponseWriter, r *http.Request)
 	}
 }
 
-func (a *Assistant) channelsHandler(w http.ResponseWriter, r *http.Request) {
+func (a *Assistant) channelsHandler(w http.ResponseWriter, _ *http.Request) {
 	channels := []config.Channel{}
 
 	w.Header().Set("Content-Type", "application/json; charset=utf-8")

pkg/connection/slacksm/assistant.go

@@ -99,6 +99,6 @@ func (m Messenger) AddArtifact(title, content, _, messageID string) (artifactLin
 }
 
 // DownloadArtifact downloads snippets from a communication channel.
-func (m Messenger) DownloadArtifact(artifactURL string) (response []byte, err error) {
+func (m Messenger) DownloadArtifact(_ string) (response []byte, err error) {
 	panic("artifact downloading is not supported")
 }