archive-push looks for "/global/pg_control" in current directory

[yennor]

Before I added the archive-push command to my postgresl config I wanted to test out if it works properly, so I called as user postgres from the command line:

/usr/bin/pg_probackup-11 archive-push -B /var/lib/pg-probackup-11/ --instance test --wal-file-path /var/lib/postgresql/11 --wal-file-name 00000001000000950000007B --remote-host=backup.example.com --remote-port=1324 --remote-user=pgbackup --log-level-console=verbose
021-04-22 11:12:27 CEST [22285]: [1-1]: ERROR: Could not open file "/etc/postgresql/11/main/global/pg_control" for reading: No such file or directory

It took me 20 minutes of reading through documentation, experiment etc. until I found out, that archive-push looks for "global/pg_control" in the current directory... (It didn't help that I was in the config directory of postgresql, so the path seemed to make halfway sense)
Please mention that in the documentation, or even better: Use the pg-data directory defined in the instance config file. I guess that would be the expected behaviour

[gsmolk]

Hello!

Please mention that in the documentation,

Sure!

Use the pg-data directory defined in the instance config file. I guess that would be the expected behaviour

Hm, I can think of at least one case were it can be harmful (instance restored in different directory), but we probably can trust the --pgdata parameter provided via cmdline.

Thank you for a feedback.

[yennor]

Hm, I can think of at least one case were it can be harmful (instance restored in different directory), but we probably can trust the --pgdata parameter provided via cmdline.

Then maybe instead of only a "error, no such file" message. Mention directly in the error message that the current directory is used unless --pgdata parameter is provided.