Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[perf]: The correct behavior for the parser. #34

Open
Scrum opened this issue Sep 3, 2019 · 0 comments
Open

[perf]: The correct behavior for the parser. #34

Scrum opened this issue Sep 3, 2019 · 0 comments

Comments

@Scrum
Copy link
Member

Scrum commented Sep 3, 2019

The correct behavior for the parser would be throwing an error in the case where unclosed tags are met, instead of silently returning wrongly parsed HTML. Otherwise that's really confusing from the level of dependent packages like posthtml-include.

I'd add that test case:

<include src="a.html"/>
<include src="b.html"/>

Otherwise I've spent, like, ~2 hours figuring that out, somebody else can get trapped there too.

Originally posted by @dy in #23 (comment)

@Scrum Scrum added this to the 0.4.2 milestone Sep 3, 2019
@Scrum Scrum changed the title The correct behavior for the parser. [perf]: The correct behavior for the parser. Sep 3, 2019
@Scrum Scrum removed this from the 0.4.3 milestone Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant