Try catching closed pool message

Author: simolus3

integrations/room/src/commonIntegrationTest/kotlin/com/powersync/integrations/room/PowerSyncRoomTest.kt

@@ -2,7 +2,9 @@ package com.powersync.integrations.room
 
 import androidx.sqlite.driver.bundled.BundledSQLiteDriver
 import app.cash.turbine.turbineScope
+import co.touchlab.kermit.CommonWriter
 import co.touchlab.kermit.Logger
+import co.touchlab.kermit.Severity
 import co.touchlab.kermit.loggerConfigInit
 import com.powersync.PowerSyncDatabase
 import com.powersync.db.getString
@@ -28,14 +30,14 @@ class PowerSyncRoomTest {
 
     @AfterTest
     fun tearDown() {
+        logger.i { "Closing Room database" }
         database.close()
     }
 
     @Test
     fun roomWritePowerSyncRead() =
         runTest {
             database.userDao().create(User(id = "test", name = "Test user"))
-            val logger = Logger(loggerConfigInit())
 
             val powersync =
                 PowerSyncDatabase.opened(
@@ -61,7 +63,6 @@ class PowerSyncRoomTest {
     @Test
     fun roomWritePowerSyncWatch() =
         runTest {
-            val logger = Logger(loggerConfigInit())
             val pool = RoomConnectionPool(database, TestDatabase.schema)
 
             val powersync =
@@ -95,7 +96,6 @@ class PowerSyncRoomTest {
     @Test
     fun powersyncWriteRoomRead() =
         runTest {
-            val logger = Logger(loggerConfigInit())
             val pool = RoomConnectionPool(database, TestDatabase.schema)
 
             val powersync =
@@ -116,7 +116,6 @@ class PowerSyncRoomTest {
     @Test
     fun powersyncWriteRoomWatch() =
         runTest {
-            val logger = Logger(loggerConfigInit())
             val pool = RoomConnectionPool(database, TestDatabase.schema)
 
             val powersync =
@@ -139,4 +138,8 @@ class PowerSyncRoomTest {
 
             powersync.close()
         }
+
+    companion object {
+        private val logger = Logger(loggerConfigInit(CommonWriter()))
+    }
 }

integrations/room/src/commonMain/kotlin/com/powersync/integrations/room/RoomConnectionPool.kt

@@ -5,6 +5,7 @@ import androidx.room.Transactor
 import androidx.room.execSQL
 import androidx.room.useReaderConnection
 import androidx.room.useWriterConnection
+import androidx.sqlite.SQLiteException
 import androidx.sqlite.SQLiteStatement
 import com.powersync.db.driver.SQLiteConnectionLease
 import com.powersync.db.driver.SQLiteConnectionPool
@@ -73,7 +74,19 @@ public class RoomConnectionPool(
         db.getCoroutineScope().launch {
             val tables = schema.rawTables.map { it.name }.toTypedArray()
             db.invalidationTracker.createFlow(*tables, emitInitialState = false).collect {
-                transferPendingRoomUpdatesToPowerSync()
+                try {
+                    transferPendingRoomUpdatesToPowerSync()
+                } catch (e: SQLiteException) {
+                    // It can happen that we get an update shortly before the database is closed. Since this is
+                    // asynchronous, we'd then be using the database in a closed state, which fails. We handle that by
+                    // stopping the flow collection.
+                    if (e.message == "Connection pool is closed") {
+                        return@collect
+                    }
+
+                    throw e
+                }
+
             }
         }
     }