Rename defaultBucketPrefix -> uniqueName.

Author: rkistner

packages/sync-rules/src/BucketSource.ts

@@ -73,11 +73,11 @@ export interface HydratedBucketSource {
  */
 export interface BucketDataSource {
   /**
-   * Bucket prefix if no transformations are defined.
+   * Unique name of the data source within a sync rules version.
    *
-   * Transformations may use this as a base, or may generate an entirely different prefix.
+   * This may be used as the basis for bucketPrefix (or it could be ignored).
    */
-  readonly defaultBucketPrefix: string;
+  readonly uniqueName: string;
 
   /**
    * For debug use only.

packages/sync-rules/src/HydrationState.ts

@@ -40,7 +40,7 @@ export interface HydrationState<
 export const DEFAULT_HYDRATION_STATE: HydrationState = {
   getBucketSourceScope(source: BucketDataSource) {
     return {
-      bucketPrefix: source.defaultBucketPrefix
+      bucketPrefix: source.uniqueName
     };
   },
   getParameterLookupScope(source) {
@@ -64,7 +64,7 @@ export function versionedHydrationState(version: number): HydrationState {
   return {
     getBucketSourceScope(source: BucketDataSource): BucketDataScope {
       return {
-        bucketPrefix: `${version}#${source.defaultBucketPrefix}`
+        bucketPrefix: `${version}#${source.uniqueName}`
       };
     },
 

packages/sync-rules/src/SqlBucketDescriptor.ts

@@ -146,7 +146,7 @@ export class BucketDefinitionDataSource implements BucketDataSource {
     return this.descriptor.bucketParameters;
   }
 
-  public get defaultBucketPrefix(): string {
+  public get uniqueName(): string {
     return this.descriptor.name;
   }
 

packages/sync-rules/src/streams/stream.ts

@@ -75,7 +75,7 @@ export class SyncStreamDataSource implements BucketDataSource {
     return [];
   }
 
-  public get defaultBucketPrefix(): string {
+  public get uniqueName(): string {
     return this.variant.defaultBucketPrefix(this.stream.name);
   }
 

packages/sync-rules/test/src/streams.test.ts

@@ -890,7 +890,7 @@ WHERE
 
     const hydrationState: HydrationState = {
       getBucketSourceScope(source) {
-        return { bucketPrefix: `${source.defaultBucketPrefix}.test` };
+        return { bucketPrefix: `${source.uniqueName}.test` };
       },
       getParameterLookupScope(source) {
         return {

packages/sync-rules/test/src/util.ts

@@ -91,7 +91,7 @@ export function identityBucketTransformer(id: string) {
  * Empty data source that can be used for testing parameter queries, where most of the functionality here is not used.
  */
 export const EMPTY_DATA_SOURCE: BucketDataSource = {
-  defaultBucketPrefix: 'mybucket',
+  uniqueName: 'mybucket',
   bucketParameters: [],
   // These are not used in the tests.
   getSourceTables: function (): Set<TablePattern> {