Skip to content

Commit 89e7399

Browse files
Christiaan LandmanChristiaan Landman
Christiaan Landman
authored and
Christiaan Landman
committed
chore: ensuring user defined flags override memory flag and removed pragma temp_store command in test (covered by makeList change)
1 parent b2f95d9 commit 89e7399

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

.changeset/gorgeous-chefs-do.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@journeyapps/react-native-quick-sqlite': patch
3+
---
4+
5+
Fixed order of makefile flags

android/CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ include_directories(
1111
)
1212

1313
add_definitions(
14-
${SQLITE_FLAGS}
1514
-DSQLITE_TEMP_STORE=2
15+
${SQLITE_FLAGS}
1616
)
1717

1818
add_library(

tests/tests/sqlite/rawQueries.spec.ts

-3
Original file line numberDiff line numberDiff line change
@@ -566,9 +566,6 @@ export function registerBaseTests() {
566566
// Execute the read test whenever a table change ocurred
567567
db.registerTablesChangedHook((update) => readTriggerCallbacks.forEach((cb) => cb()));
568568

569-
// Needed for large volumes of data on older Android devices
570-
// https://github.com/margelo/react-native-quick-sqlite/pull/25
571-
await db.execute('PRAGMA temp_store = memory;')
572569
const numberOfUsers = 100_000;
573570
await db.writeLock(async (tx) => {
574571
await tx.execute('BEGIN');

0 commit comments

Comments
 (0)