Skip to content

Commit c47b324

Browse files
use defined testUtils for generateSourceTableTests
1 parent 3b5bdfc commit c47b324

File tree

3 files changed

+17
-7
lines changed

3 files changed

+17
-7
lines changed

test/native/watch_test.dart

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,13 @@ void main() {
2121
await testUtils.cleanDb(path: path);
2222
});
2323

24-
generateSourceTableTests(testUtils.findSqliteLibraries(), () => path);
24+
generateSourceTableTests(testUtils.findSqliteLibraries(),
25+
(String sqlitePath) async {
26+
final db =
27+
SqliteDatabase.withFactory(await testUtils.testFactory(path: path));
28+
await db.initialize();
29+
return db;
30+
});
2531

2632
test('watch in isolate', () async {
2733
final db = await testUtils.setupDatabase(path: path);

test/watch_test.dart

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,11 @@ createTables(SqliteDatabase db) async {
2222
}
2323

2424
// Web and native have different requirements for `sqlitePaths`.
25-
void generateSourceTableTests(
26-
List<String> sqlitePaths, String Function() getPath) {
25+
void generateSourceTableTests(List<String> sqlitePaths,
26+
Future<SqliteDatabase> Function(String sqlitePath) generateDB) {
2727
for (var sqlite in sqlitePaths) {
2828
test('getSourceTables - $sqlite', () async {
29-
final db = SqliteDatabase.withFactory(
30-
await testUtils.testFactory(path: getPath(), sqlitePath: sqlite));
31-
await db.initialize();
29+
final db = await generateDB(sqlite);
3230
await createTables(db);
3331

3432
var versionRow = await db.get('SELECT sqlite_version() as version');

test/web/watch_test.dart

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
@TestOn('browser')
2+
import 'package:sqlite_async/sqlite_async.dart';
23
import 'package:test/test.dart';
34

45
import '../utils/test_utils_impl.dart';
@@ -18,6 +19,11 @@ void main() {
1819

1920
/// Can't use testUtils instance here since it requires spawnHybridUri
2021
/// which is not available when declaring tests
21-
generateSourceTableTests(['sqlite3.wasm'], () => path);
22+
generateSourceTableTests(['sqlite3.wasm'], (String sqlitePath) async {
23+
final db =
24+
SqliteDatabase.withFactory(await testUtils.testFactory(path: path));
25+
await db.initialize();
26+
return db;
27+
});
2228
});
2329
}

0 commit comments

Comments
 (0)