Skip to content

Commit d37e09e

Browse files
committed
Change open DB to be synchronous
1 parent d5bc6a3 commit d37e09e

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

example/custom_functions_example.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ class TestOpenFactory extends DefaultSqliteOpenFactory {
1111
TestOpenFactory({required super.path, super.sqliteOptions});
1212

1313
@override
14-
FutureOr<CommonDatabase> open(SqliteOpenOptions options) async {
15-
final db = await super.open(options);
14+
CommonDatabase open(SqliteOpenOptions options) {
15+
final db = super.open(options);
1616

1717
db.createFunction(
1818
functionName: 'sleep',

example/linux_cli_example.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ class TestOpenFactory extends DefaultSqliteOpenFactory {
1717
this.sqlitePath = defaultSqlitePath});
1818

1919
@override
20-
FutureOr<CommonDatabase> open(SqliteOpenOptions options) async {
20+
CommonDatabase open(SqliteOpenOptions options) {
2121
// For details, see:
2222
// https://pub.dev/packages/sqlite3#manually-providing-sqlite3-libraries
2323
sqlite_open.open.overrideFor(sqlite_open.OperatingSystem.linux, () {

lib/src/common/abstract_open_factory.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ abstract class SqliteOpenFactory<Database extends sqlite.CommonDatabase> {
1515
String get path;
1616

1717
/// Opens a direct connection to the SQLite database
18-
FutureOr<Database> open(SqliteOpenOptions options);
18+
Database open(SqliteOpenOptions options);
1919

2020
/// Opens an asynchronous [SqliteConnection]
2121
FutureOr<SqliteConnection> openConnection(SqliteOpenOptions options);
@@ -77,14 +77,14 @@ abstract class AbstractDefaultSqliteOpenFactory<
7777
@protected
7878

7979
/// Opens a direct connection to a SQLite database connection
80-
FutureOr<Database> openDB(SqliteOpenOptions options);
80+
Database openDB(SqliteOpenOptions options);
8181

8282
@override
8383

8484
/// Opens a direct connection to a SQLite database connection
8585
/// and executes setup pragma statements to initialize the DB
86-
FutureOr<Database> open(SqliteOpenOptions options) async {
87-
var db = await openDB(options);
86+
Database open(SqliteOpenOptions options) {
87+
var db = openDB(options);
8888

8989
// Pragma statements don't have the same BUSY_TIMEOUT behavior as normal statements.
9090
// We add a manual retry loop for those.

test/utils/native_test_utils.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,11 @@ class TestSqliteOpenFactory extends TestDefaultSqliteOpenFactory {
2121
initStatements});
2222

2323
@override
24-
FutureOr<CommonDatabase> open(SqliteOpenOptions options) async {
24+
CommonDatabase open(SqliteOpenOptions options) {
2525
sqlite_open.open.overrideFor(sqlite_open.OperatingSystem.linux, () {
2626
return DynamicLibrary.open(sqlitePath);
2727
});
28-
final db = await super.open(options);
28+
final db = super.open(options);
2929

3030
db.createFunction(
3131
functionName: 'test_sleep',

0 commit comments

Comments
 (0)