Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency policy #908

Open
Helveg opened this issue Apr 29, 2024 · 1 comment
Open

Dependency policy #908

Helveg opened this issue Apr 29, 2024 · 1 comment

Comments

@Helveg
Copy link
Collaborator

Helveg commented Apr 29, 2024

The Renovate Bot seems to update our peer dependencies rather aggressively. peerDependencies should be as relaxed as possible, even spanning multiple major versions like: "@nestjs/common": "7 || 8 || 9 || 10". Peer dependencies reflect compatibility with a peer package. Since we are a NestJS and TypeORM plugin, I believe we should strive to keep every version compatible with as many supported major versions as possible, as not to over-restrict users of nestjs-paginate to the very latest versions of our peer deps.

We seem to be coupled to express and fastify as well for a couple of cases, there too relaxing the constraints would increase our compatibility.

I would strive for a compatibility policy like "we'll aim to support the last 2 major versions of Nest, express and fastify, and the last 3 minor versions of typeorm at the time of nestjs-paginate release"

@ppetzold
Copy link
Owner

Good point. Renovate is ignoring peer deps now - but I only set support all current majors (can be lowered if needed). Typeorm is still set to ^0.3.17 as it doesn't follow semver 🤔

57ea1a5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants