autogen: run to update randombytes() declaration

L-series · L-series · commit 21c81f1ba680 · 2025-11-12T11:08:35.000-05:00
Run the autogen script to reflect the changes made to the randombytes()
API.

Signed-off-by: Andreas Hatziiliou &lt;andreas.hatziiliou@savoirfairelinux.com&gt;
diff --git a/examples/basic_deterministic/mldsa_native/custom_no_randomized_config.h b/examples/basic_deterministic/mldsa_native/custom_no_randomized_config.h
@@ -343,7 +343,8 @@
  *              consumer.
  *
  *              If this option is not set, mldsa-native expects a function
- *              void randombytes(uint8_t *out, size_t outlen).
+ *              int randombytes(uint8_t *out, size_t outlen).
+ *              This function should return 0 on success, non-zero on failure.
  *
  *              Set this option and define `mld_randombytes` if you want to
  *              use a custom method to sample randombytes with a different name
@@ -354,9 +355,10 @@
    #if !defined(__ASSEMBLER__)
    #include <stdint.h>
    #include "sys.h"
-   static MLD_INLINE void mld_randombytes(uint8_t *ptr, size_t len)
+   static MLD_INLINE int mld_randombytes(uint8_t *ptr, size_t len)
    {
        ... your implementation ...
+       return 0;  // 0 on success, non-zero on failure
    }
    #endif
 */
diff --git a/examples/monolithic_build/config_44.h b/examples/monolithic_build/config_44.h
@@ -341,7 +341,8 @@
  *              consumer.
  *
  *              If this option is not set, mldsa-native expects a function
- *              void randombytes(uint8_t *out, size_t outlen).
+ *              int randombytes(uint8_t *out, size_t outlen).
+ *              This function should return 0 on success, non-zero on failure.
  *
  *              Set this option and define `mld_randombytes` if you want to
  *              use a custom method to sample randombytes with a different name
@@ -352,9 +353,10 @@
    #if !defined(__ASSEMBLER__)
    #include <stdint.h>
    #include "sys.h"
-   static MLD_INLINE void mld_randombytes(uint8_t *ptr, size_t len)
+   static MLD_INLINE int mld_randombytes(uint8_t *ptr, size_t len)
    {
        ... your implementation ...
+       return 0;  // 0 on success, non-zero on failure
    }
    #endif
 */
diff --git a/examples/monolithic_build/config_65.h b/examples/monolithic_build/config_65.h
@@ -341,7 +341,8 @@
  *              consumer.
  *
  *              If this option is not set, mldsa-native expects a function
- *              void randombytes(uint8_t *out, size_t outlen).
+ *              int randombytes(uint8_t *out, size_t outlen).
+ *              This function should return 0 on success, non-zero on failure.
  *
  *              Set this option and define `mld_randombytes` if you want to
  *              use a custom method to sample randombytes with a different name
@@ -352,9 +353,10 @@
    #if !defined(__ASSEMBLER__)
    #include <stdint.h>
    #include "sys.h"
-   static MLD_INLINE void mld_randombytes(uint8_t *ptr, size_t len)
+   static MLD_INLINE int mld_randombytes(uint8_t *ptr, size_t len)
    {
        ... your implementation ...
+       return 0;  // 0 on success, non-zero on failure
    }
    #endif
 */
diff --git a/examples/monolithic_build/config_87.h b/examples/monolithic_build/config_87.h
@@ -341,7 +341,8 @@
  *              consumer.
  *
  *              If this option is not set, mldsa-native expects a function
- *              void randombytes(uint8_t *out, size_t outlen).
+ *              int randombytes(uint8_t *out, size_t outlen).
+ *              This function should return 0 on success, non-zero on failure.
  *
  *              Set this option and define `mld_randombytes` if you want to
  *              use a custom method to sample randombytes with a different name
@@ -352,9 +353,10 @@
    #if !defined(__ASSEMBLER__)
    #include <stdint.h>
    #include "sys.h"
-   static MLD_INLINE void mld_randombytes(uint8_t *ptr, size_t len)
+   static MLD_INLINE int mld_randombytes(uint8_t *ptr, size_t len)
    {
        ... your implementation ...
+       return 0;  // 0 on success, non-zero on failure
    }
    #endif
 */
diff --git a/examples/monolithic_build_multilevel/multilevel_config.h b/examples/monolithic_build_multilevel/multilevel_config.h
@@ -342,7 +342,8 @@
  *              consumer.
  *
  *              If this option is not set, mldsa-native expects a function
- *              void randombytes(uint8_t *out, size_t outlen).
+ *              int randombytes(uint8_t *out, size_t outlen).
+ *              This function should return 0 on success, non-zero on failure.
  *
  *              Set this option and define `mld_randombytes` if you want to
  *              use a custom method to sample randombytes with a different name
@@ -353,9 +354,10 @@
    #if !defined(__ASSEMBLER__)
    #include <stdint.h>
    #include "sys.h"
-   static MLD_INLINE void mld_randombytes(uint8_t *ptr, size_t len)
+   static MLD_INLINE int mld_randombytes(uint8_t *ptr, size_t len)
    {
        ... your implementation ...
+       return 0;  // 0 on success, non-zero on failure
    }
    #endif
 */
diff --git a/mldsa/src/config.h b/mldsa/src/config.h
@@ -327,7 +327,8 @@
  *              consumer.
  *
  *              If this option is not set, mldsa-native expects a function
- *              void randombytes(uint8_t *out, size_t outlen).
+ *              int randombytes(uint8_t *out, size_t outlen).
+ *              This function should return 0 on success, non-zero on failure.
  *
  *              Set this option and define `mld_randombytes` if you want to
  *              use a custom method to sample randombytes with a different name
@@ -338,9 +339,10 @@
    #if !defined(__ASSEMBLER__)
    #include <stdint.h>
    #include "sys.h"
-   static MLD_INLINE void mld_randombytes(uint8_t *ptr, size_t len)
+   static MLD_INLINE int mld_randombytes(uint8_t *ptr, size_t len)
    {
        ... your implementation ...
+       return 0;  // 0 on success, non-zero on failure
    }
    #endif
 */
diff --git a/mldsa/src/debug.h b/mldsa/src/debug.h
@@ -91,14 +91,14 @@ void mld_debug_check_bounds(const char *file, int line, const int32_t *ptr,
 
 /* Because of https://github.com/diffblue/cbmc/issues/8570, we can't
  * just use a single flattened array_bound(...) here. */
-#define mld_assert_bound_2d(ptr, M, N, value_lb, value_ub)             \
-  cassert(forall(kN, 0, (M),                                           \
-                 array_bound(&((int32_t(*)[(N)])(ptr))[kN][0], 0, (N), \
+#define mld_assert_bound_2d(ptr, M, N, value_lb, value_ub)              \
+  cassert(forall(kN, 0, (M),                                            \
+                 array_bound(&((int32_t (*)[(N)])(ptr))[kN][0], 0, (N), \
                              (value_lb), (value_ub))))
 
-#define mld_assert_abs_bound_2d(ptr, M, N, value_abs_bd)                   \
-  cassert(forall(kN, 0, (M),                                               \
-                 array_abs_bound(&((int32_t(*)[(N)])(ptr))[kN][0], 0, (N), \
+#define mld_assert_abs_bound_2d(ptr, M, N, value_abs_bd)                    \
+  cassert(forall(kN, 0, (M),                                                \
+                 array_abs_bound(&((int32_t (*)[(N)])(ptr))[kN][0], 0, (N), \
                                  (value_abs_bd))))
 
 #else /* !MLDSA_DEBUG && CBMC */
diff --git a/mldsa/src/polyvec.c b/mldsa/src/polyvec.c
@@ -334,26 +334,26 @@ void mld_polyvecl_pointwise_acc_montgomery(mld_poly *w, const mld_polyvecl *u,
   mld_assert_bound_2d(u->vec, MLDSA_L, MLDSA_N, 0, MLDSA_Q);
   mld_assert_abs_bound_2d(v->vec, MLDSA_L, MLDSA_N, MLD_NTT_BOUND);
   mld_polyvecl_pointwise_acc_montgomery_l4_native(
-      w->coeffs, (const int32_t(*)[MLDSA_N])u->vec,
-      (const int32_t(*)[MLDSA_N])v->vec);
+      w->coeffs, (const int32_t (*)[MLDSA_N])u->vec,
+      (const int32_t (*)[MLDSA_N])v->vec);
   mld_assert_abs_bound(w->coeffs, MLDSA_N, MLDSA_Q);
 #elif defined(MLD_USE_NATIVE_POLYVECL_POINTWISE_ACC_MONTGOMERY_L5) && \
     MLD_CONFIG_PARAMETER_SET == 65
   /* TODO: proof */
   mld_assert_bound_2d(u->vec, MLDSA_L, MLDSA_N, 0, MLDSA_Q);
   mld_assert_abs_bound_2d(v->vec, MLDSA_L, MLDSA_N, MLD_NTT_BOUND);
   mld_polyvecl_pointwise_acc_montgomery_l5_native(
-      w->coeffs, (const int32_t(*)[MLDSA_N])u->vec,
-      (const int32_t(*)[MLDSA_N])v->vec);
+      w->coeffs, (const int32_t (*)[MLDSA_N])u->vec,
+      (const int32_t (*)[MLDSA_N])v->vec);
   mld_assert_abs_bound(w->coeffs, MLDSA_N, MLDSA_Q);
 #elif defined(MLD_USE_NATIVE_POLYVECL_POINTWISE_ACC_MONTGOMERY_L7) && \
     MLD_CONFIG_PARAMETER_SET == 87
   /* TODO: proof */
   mld_assert_bound_2d(u->vec, MLDSA_L, MLDSA_N, 0, MLDSA_Q);
   mld_assert_abs_bound_2d(v->vec, MLDSA_L, MLDSA_N, MLD_NTT_BOUND);
   mld_polyvecl_pointwise_acc_montgomery_l7_native(
-      w->coeffs, (const int32_t(*)[MLDSA_N])u->vec,
-      (const int32_t(*)[MLDSA_N])v->vec);
+      w->coeffs, (const int32_t (*)[MLDSA_N])u->vec,
+      (const int32_t (*)[MLDSA_N])v->vec);
   mld_assert_abs_bound(w->coeffs, MLDSA_N, MLDSA_Q);
 #else  /* !(MLD_USE_NATIVE_POLYVECL_POINTWISE_ACC_MONTGOMERY_L4 && \
           MLD_CONFIG_PARAMETER_SET == 44) &&                       \
diff --git a/proofs/cbmc/poly_uniform_4x/poly_uniform_4x_harness.c b/proofs/cbmc/poly_uniform_4x/poly_uniform_4x_harness.c
@@ -9,7 +9,7 @@ void harness(void)
   mld_poly *r1;
   mld_poly *r2;
   mld_poly *r3;
-  uint8_t(*seed)[MLD_ALIGN_UP(MLDSA_SEEDBYTES + 2)];
+  uint8_t (*seed)[MLD_ALIGN_UP(MLDSA_SEEDBYTES + 2)];
 
   mld_poly_uniform_4x(r0, r1, r2, r3, seed);
 }
diff --git a/test/break_pct_config.h b/test/break_pct_config.h
@@ -343,7 +343,8 @@
  *              consumer.
  *
  *              If this option is not set, mldsa-native expects a function
- *              void randombytes(uint8_t *out, size_t outlen).
+ *              int randombytes(uint8_t *out, size_t outlen).
+ *              This function should return 0 on success, non-zero on failure.
  *
  *              Set this option and define `mld_randombytes` if you want to
  *              use a custom method to sample randombytes with a different name
@@ -354,9 +355,10 @@
    #if !defined(__ASSEMBLER__)
    #include <stdint.h>
    #include "sys.h"
-   static MLD_INLINE void mld_randombytes(uint8_t *ptr, size_t len)
+   static MLD_INLINE int mld_randombytes(uint8_t *ptr, size_t len)
    {
        ... your implementation ...
+       return 0;  // 0 on success, non-zero on failure
    }
    #endif
 */
diff --git a/test/custom_memcpy_config.h b/test/custom_memcpy_config.h
@@ -350,7 +350,8 @@ static MLD_INLINE void *mld_memcpy(void *dest, const void *src, size_t n)
  *              consumer.
  *
  *              If this option is not set, mldsa-native expects a function
- *              void randombytes(uint8_t *out, size_t outlen).
+ *              int randombytes(uint8_t *out, size_t outlen).
+ *              This function should return 0 on success, non-zero on failure.
  *
  *              Set this option and define `mld_randombytes` if you want to
  *              use a custom method to sample randombytes with a different name
@@ -361,9 +362,10 @@ static MLD_INLINE void *mld_memcpy(void *dest, const void *src, size_t n)
    #if !defined(__ASSEMBLER__)
    #include <stdint.h>
    #include "sys.h"
-   static MLD_INLINE void mld_randombytes(uint8_t *ptr, size_t len)
+   static MLD_INLINE int mld_randombytes(uint8_t *ptr, size_t len)
    {
        ... your implementation ...
+       return 0;  // 0 on success, non-zero on failure
    }
    #endif
 */
diff --git a/test/custom_memset_config.h b/test/custom_memset_config.h
@@ -349,7 +349,8 @@ static MLD_INLINE void *mld_memset(void *s, int c, size_t n)
  *              consumer.
  *
  *              If this option is not set, mldsa-native expects a function
- *              void randombytes(uint8_t *out, size_t outlen).
+ *              int randombytes(uint8_t *out, size_t outlen).
+ *              This function should return 0 on success, non-zero on failure.
  *
  *              Set this option and define `mld_randombytes` if you want to
  *              use a custom method to sample randombytes with a different name
@@ -360,9 +361,10 @@ static MLD_INLINE void *mld_memset(void *s, int c, size_t n)
    #if !defined(__ASSEMBLER__)
    #include <stdint.h>
    #include "sys.h"
-   static MLD_INLINE void mld_randombytes(uint8_t *ptr, size_t len)
+   static MLD_INLINE int mld_randombytes(uint8_t *ptr, size_t len)
    {
        ... your implementation ...
+       return 0;  // 0 on success, non-zero on failure
    }
    #endif
 */
diff --git a/test/custom_randombytes_config.h b/test/custom_randombytes_config.h
@@ -342,7 +342,8 @@
  *              consumer.
  *
  *              If this option is not set, mldsa-native expects a function
- *              void randombytes(uint8_t *out, size_t outlen).
+ *              int randombytes(uint8_t *out, size_t outlen).
+ *              This function should return 0 on success, non-zero on failure.
  *
  *              Set this option and define `mld_randombytes` if you want to
  *              use a custom method to sample randombytes with a different name
diff --git a/test/custom_stdlib_config.h b/test/custom_stdlib_config.h
@@ -358,7 +358,8 @@ static MLD_INLINE void *mld_memset(void *s, int c, size_t n)
  *              consumer.
  *
  *              If this option is not set, mldsa-native expects a function
- *              void randombytes(uint8_t *out, size_t outlen).
+ *              int randombytes(uint8_t *out, size_t outlen).
+ *              This function should return 0 on success, non-zero on failure.
  *
  *              Set this option and define `mld_randombytes` if you want to
  *              use a custom method to sample randombytes with a different name
@@ -369,9 +370,10 @@ static MLD_INLINE void *mld_memset(void *s, int c, size_t n)
    #if !defined(__ASSEMBLER__)
    #include <stdint.h>
    #include "sys.h"
-   static MLD_INLINE void mld_randombytes(uint8_t *ptr, size_t len)
+   static MLD_INLINE int mld_randombytes(uint8_t *ptr, size_t len)
    {
        ... your implementation ...
+       return 0;  // 0 on success, non-zero on failure
    }
    #endif
 */
diff --git a/test/custom_zeroize_config.h b/test/custom_zeroize_config.h
@@ -343,7 +343,8 @@ static MLD_INLINE void mld_zeroize_native(void *ptr, size_t len)
  *              consumer.
  *
  *              If this option is not set, mldsa-native expects a function
- *              void randombytes(uint8_t *out, size_t outlen).
+ *              int randombytes(uint8_t *out, size_t outlen).
+ *              This function should return 0 on success, non-zero on failure.
  *
  *              Set this option and define `mld_randombytes` if you want to
  *              use a custom method to sample randombytes with a different name
@@ -354,9 +355,10 @@ static MLD_INLINE void mld_zeroize_native(void *ptr, size_t len)
    #if !defined(__ASSEMBLER__)
    #include <stdint.h>
    #include "sys.h"
-   static MLD_INLINE void mld_randombytes(uint8_t *ptr, size_t len)
+   static MLD_INLINE int mld_randombytes(uint8_t *ptr, size_t len)
    {
        ... your implementation ...
+       return 0;  // 0 on success, non-zero on failure
    }
    #endif
 */
diff --git a/test/no_asm_config.h b/test/no_asm_config.h
@@ -344,7 +344,8 @@ static MLD_INLINE void mld_zeroize_native(void *ptr, size_t len)
  *              consumer.
  *
  *              If this option is not set, mldsa-native expects a function
- *              void randombytes(uint8_t *out, size_t outlen).
+ *              int randombytes(uint8_t *out, size_t outlen).
+ *              This function should return 0 on success, non-zero on failure.
  *
  *              Set this option and define `mld_randombytes` if you want to
  *              use a custom method to sample randombytes with a different name
@@ -355,9 +356,10 @@ static MLD_INLINE void mld_zeroize_native(void *ptr, size_t len)
    #if !defined(__ASSEMBLER__)
    #include <stdint.h>
    #include "sys.h"
-   static MLD_INLINE void mld_randombytes(uint8_t *ptr, size_t len)
+   static MLD_INLINE int mld_randombytes(uint8_t *ptr, size_t len)
    {
        ... your implementation ...
+       return 0;  // 0 on success, non-zero on failure
    }
    #endif
 */
diff --git a/test/serial_fips202_config.h b/test/serial_fips202_config.h
@@ -342,7 +342,8 @@
  *              consumer.
  *
  *              If this option is not set, mldsa-native expects a function
- *              void randombytes(uint8_t *out, size_t outlen).
+ *              int randombytes(uint8_t *out, size_t outlen).
+ *              This function should return 0 on success, non-zero on failure.
  *
  *              Set this option and define `mld_randombytes` if you want to
  *              use a custom method to sample randombytes with a different name
@@ -353,9 +354,10 @@
    #if !defined(__ASSEMBLER__)
    #include <stdint.h>
    #include "sys.h"
-   static MLD_INLINE void mld_randombytes(uint8_t *ptr, size_t len)
+   static MLD_INLINE int mld_randombytes(uint8_t *ptr, size_t len)
    {
        ... your implementation ...
+       return 0;  // 0 on success, non-zero on failure
    }
    #endif
 */

Original file line number	Diff line number	Diff line change
`@@ -343,7 +343,8 @@`
`343`	`343`	`* consumer.`
`344`	`344`	`*`
`345`	`345`	`* If this option is not set, mldsa-native expects a function`
`346`		`- * void randombytes(uint8_t *out, size_t outlen).`
	`346`	`+ * int randombytes(uint8_t *out, size_t outlen).`
	`347`	`+ * This function should return 0 on success, non-zero on failure.`
`347`	`348`	`*`
`348`	`349`	* Set this option and define `mld_randombytes` if you want to
`349`	`350`	`* use a custom method to sample randombytes with a different name`
`@@ -354,9 +355,10 @@`
`354`	`355`	`#if !defined(__ASSEMBLER__)`
`355`	`356`	`#include <stdint.h>`
`356`	`357`	`#include "sys.h"`
`357`		`- static MLD_INLINE void mld_randombytes(uint8_t *ptr, size_t len)`
	`358`	`+ static MLD_INLINE int mld_randombytes(uint8_t *ptr, size_t len)`
`358`	`359`	`{`
`359`	`360`	`... your implementation ...`
	`361`	`+ return 0; // 0 on success, non-zero on failure`
`360`	`362`	`}`
`361`	`363`	`#endif`
`362`	`364`	`*/`
Original file line number	Diff line number	Diff line change
`@@ -341,7 +341,8 @@`
`341`	`341`	`* consumer.`
`342`	`342`	`*`
`343`	`343`	`* If this option is not set, mldsa-native expects a function`
`344`		`- * void randombytes(uint8_t *out, size_t outlen).`
	`344`	`+ * int randombytes(uint8_t *out, size_t outlen).`
	`345`	`+ * This function should return 0 on success, non-zero on failure.`
`345`	`346`	`*`
`346`	`347`	* Set this option and define `mld_randombytes` if you want to
`347`	`348`	`* use a custom method to sample randombytes with a different name`
`@@ -352,9 +353,10 @@`
`352`	`353`	`#if !defined(__ASSEMBLER__)`
`353`	`354`	`#include <stdint.h>`
`354`	`355`	`#include "sys.h"`
`355`		`- static MLD_INLINE void mld_randombytes(uint8_t *ptr, size_t len)`
	`356`	`+ static MLD_INLINE int mld_randombytes(uint8_t *ptr, size_t len)`
`356`	`357`	`{`
`357`	`358`	`... your implementation ...`
	`359`	`+ return 0; // 0 on success, non-zero on failure`
`358`	`360`	`}`
`359`	`361`	`#endif`
`360`	`362`	`*/`
Original file line number	Diff line number	Diff line change
`@@ -342,7 +342,8 @@`
`342`	`342`	`* consumer.`
`343`	`343`	`*`
`344`	`344`	`* If this option is not set, mldsa-native expects a function`
`345`		`- * void randombytes(uint8_t *out, size_t outlen).`
	`345`	`+ * int randombytes(uint8_t *out, size_t outlen).`
	`346`	`+ * This function should return 0 on success, non-zero on failure.`
`346`	`347`	`*`
`347`	`348`	* Set this option and define `mld_randombytes` if you want to
`348`	`349`	`* use a custom method to sample randombytes with a different name`
`@@ -353,9 +354,10 @@`
`353`	`354`	`#if !defined(__ASSEMBLER__)`
`354`	`355`	`#include <stdint.h>`
`355`	`356`	`#include "sys.h"`
`356`		`- static MLD_INLINE void mld_randombytes(uint8_t *ptr, size_t len)`
	`357`	`+ static MLD_INLINE int mld_randombytes(uint8_t *ptr, size_t len)`
`357`	`358`	`{`
`358`	`359`	`... your implementation ...`
	`360`	`+ return 0; // 0 on success, non-zero on failure`
`359`	`361`	`}`
`360`	`362`	`#endif`
`361`	`363`	`*/`
Original file line number	Diff line number	Diff line change
`@@ -327,7 +327,8 @@`
`327`	`327`	`* consumer.`
`328`	`328`	`*`
`329`	`329`	`* If this option is not set, mldsa-native expects a function`
`330`		`- * void randombytes(uint8_t *out, size_t outlen).`
	`330`	`+ * int randombytes(uint8_t *out, size_t outlen).`
	`331`	`+ * This function should return 0 on success, non-zero on failure.`
`331`	`332`	`*`
`332`	`333`	* Set this option and define `mld_randombytes` if you want to
`333`	`334`	`* use a custom method to sample randombytes with a different name`
`@@ -338,9 +339,10 @@`
`338`	`339`	`#if !defined(__ASSEMBLER__)`
`339`	`340`	`#include <stdint.h>`
`340`	`341`	`#include "sys.h"`
`341`		`- static MLD_INLINE void mld_randombytes(uint8_t *ptr, size_t len)`
	`342`	`+ static MLD_INLINE int mld_randombytes(uint8_t *ptr, size_t len)`
`342`	`343`	`{`
`343`	`344`	`... your implementation ...`
	`345`	`+ return 0; // 0 on success, non-zero on failure`
`344`	`346`	`}`
`345`	`347`	`#endif`
`346`	`348`	`*/`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ void harness(void)`
`9`	`9`	`mld_poly *r1;`
`10`	`10`	`mld_poly *r2;`
`11`	`11`	`mld_poly *r3;`
`12`		`- uint8_t(*seed)[MLD_ALIGN_UP(MLDSA_SEEDBYTES + 2)];`
	`12`	`+ uint8_t (*seed)[MLD_ALIGN_UP(MLDSA_SEEDBYTES + 2)];`
`13`	`13`
`14`	`14`	`mld_poly_uniform_4x(r0, r1, r2, r3, seed);`
`15`	`15`	`}`