Optimized code

Author: praharshjain

LICENSE

@@ -20,16 +20,15 @@ class LinkedList
         size = 0;
         start = NULL;
     }
-    struct node<T> *create_node(T value)
+    struct node<T> *create_node(const T value)
     {
         struct node<T> *temp = new (struct node<T>);
         temp->next = NULL;
         temp->data = value;
         return temp;
     }
     // functions to insert values
-    void
-    insert_begin(T value)
+    void insert_begin(const T value)
     {
         struct node<T> *temp = create_node(value);
         if (start != NULL)
@@ -39,7 +38,7 @@ class LinkedList
         start = temp;
         size++;
     }
-    void insert(T value)
+    void insert(const T value)
     {
         struct node<T> *temp = start;
         if (temp != NULL)
@@ -54,7 +53,7 @@ class LinkedList
             insert_begin(value);
         }
     }
-    void insert_pos(T value, int pos)
+    void insert_pos(const T value, int pos)
     {
         if (pos == 1)
         {
@@ -81,7 +80,7 @@ class LinkedList
         }
     }
     // search the list
-    int search(T value)
+    int search(const T value)
     {
         struct node<T> *temp = start;
         for (int pos = 1; temp != NULL; pos++)
@@ -95,7 +94,7 @@ class LinkedList
         return -1;
     }
     // delete from list
-    void remove_pos(int pos)
+    void remove_pos(const int pos)
     {
         if (pos > 1 && pos <= size)
         {
@@ -121,7 +120,7 @@ class LinkedList
             cout << "\nNo such entry in list\n";
         }
     }
-    void remove(T value)
+    void remove(const T value)
     {
         remove_pos(search(value));
     }

README.md

@@ -1,12 +1,25 @@
-#include <iostream>
-#include <cstdlib>
+#include <bits/stdc++.h>
 using namespace std;
-const int MAX_SIZE = 100;
+class QueueFullException : public exception
+{
+    virtual const char *what() const throw()
+    {
+        return "\nQueue is full\n";
+    }
+};
+class QueueEmptyException : public exception
+{
+    virtual const char *what() const throw()
+    {
+        return "\nQueue is empty\n";
+    }
+};
 //generic implementation of standard Queue data structure using templates
 template <class T>
 class Queue
 {
   private:
+    static const int MAX_SIZE = 100;
     T data[MAX_SIZE];
     int front;
     int rear;
@@ -18,28 +31,46 @@ class Queue
         rear = 0;
     }
 
-    void Enqueue(T element)
+    void Enqueue(const T element)
     {
         if (Size() == MAX_SIZE - 1)
-            cout << "Queue full\n";
-        data[rear] = element;
-        rear = ++rear % MAX_SIZE;
+        {
+            QueueFullException e;
+            throw e;
+        }
+        else
+        {
+            data[rear] = element;
+            rear = ++rear % MAX_SIZE;
+        }
     }
 
-    int Dequeue()
+    T Dequeue()
     {
         if (isEmpty())
-            cout << "Queue empty\n";
-        T ret = data[front];
-        front = ++front % MAX_SIZE;
-        return ret;
+        {
+            QueueEmptyException e;
+            throw e;
+        }
+        else
+        {
+            T ret = data[front];
+            front = ++front % MAX_SIZE;
+            return ret;
+        }
     }
 
-    int Front()
+    T Front()
     {
         if (isEmpty())
-            cout << "Queue empty\n";
-        return data[front];
+        {
+            QueueEmptyException e;
+            throw e;
+        }
+        else
+        {
+            return data[front];
+        }
     }
 
     int Size()

linked_list.cpp

@@ -1,11 +1,25 @@
 #include <iostream>
 using namespace std;
-const int MAX_SIZE = 100;
+class StackoverflowException : public exception
+{
+    virtual const char *what() const throw()
+    {
+        return "\nStack overflow\n";
+    }
+};
+class StackunderflowException : public exception
+{
+    virtual const char *what() const throw()
+    {
+        return "\nStack underflow\n";
+    }
+};
 //generic implementation of standard Stack data structure using templates
 template <class T>
 class Stack
 {
   private:
+    static const int MAX_SIZE = 100;
     T data[MAX_SIZE];
     int top;
 
@@ -15,37 +29,61 @@ class Stack
         top = -1;
     }
 
-    void Push(T element)
+    void Push(const T element)
     {
         if (top >= MAX_SIZE)
         {
-            cout << "Stack overflow\n";
+            StackoverflowException e;
+            throw e;
+        }
+        else
+        {
+            data[++top] = element;
         }
-        data[++top] = element;
     }
 
     T Pop()
     {
-        if (top == -1)
+        if (top <= -1)
         {
-            cout << "Stack underflow\n";
+            StackunderflowException e;
+            throw e;
+        }
+        else
+        {
+            return data[top--];
         }
-        return data[top--];
     }
 
     T Top()
     {
-        return data[top];
+        if (top <= -1)
+        {
+            StackunderflowException e;
+            throw e;
+        }
+        else
+        {
+            return data[top];
+        }
     }
 
     int Size()
     {
-        return top + 1;
+        if (top <= -1)
+        {
+            StackunderflowException e;
+            throw e;
+        }
+        else
+        {
+            return top + 1;
+        }
     }
 
     bool isEmpty()
     {
-        return (top == -1) ? true : false;
+        return (top <= -1) ? true : false;
     }
 };