Skip to content

Commit 2b8acfa

Browse files
committed
app: fix portal positioning for sidebar menus and tooltips by removing conditional mount logic
1 parent b83282b commit 2b8acfa

4 files changed

Lines changed: 3 additions & 4 deletions

File tree

packages/app/src/pages/layout.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1960,7 +1960,7 @@ export default function Layout(props: ParentProps) {
19601960
}}
19611961
aria-label={language.t("common.moreOptions")}
19621962
/>
1963-
<DropdownMenu.Portal mount={!panelProps.mobile ? state.nav : undefined}>
1963+
<DropdownMenu.Portal>
19641964
<DropdownMenu.Content class="mt-1">
19651965
<DropdownMenu.Item onSelect={() => showEditProjectDialog(p())}>
19661966
<DropdownMenu.ItemLabel>{language.t("common.edit")}</DropdownMenu.ItemLabel>

packages/app/src/pages/layout/sidebar-items.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,6 @@ const SessionHoverPreview = (props: {
163163
gutter={16}
164164
shift={-2}
165165
trigger={props.trigger}
166-
mount={!props.mobile ? props.nav() : undefined}
167166
open={props.hoverSession() === props.session.id}
168167
onOpenChange={(open) => props.setHoverSession(open ? props.session.id : undefined)}
169168
>

packages/app/src/pages/layout/sidebar-project.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ const ProjectTile = (props: {
137137
>
138138
<ProjectIcon project={props.project} notify />
139139
</ContextMenu.Trigger>
140-
<ContextMenu.Portal mount={!props.mobile ? props.nav() : undefined}>
140+
<ContextMenu.Portal>
141141
<ContextMenu.Content>
142142
<ContextMenu.Item onSelect={() => props.showEditProjectDialog(props.project)}>
143143
<ContextMenu.ItemLabel>{props.language.t("common.edit")}</ContextMenu.ItemLabel>

packages/app/src/pages/layout/sidebar-workspace.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ const WorkspaceActions = (props: {
182182
aria-label={props.language.t("common.moreOptions")}
183183
/>
184184
</Tooltip>
185-
<DropdownMenu.Portal mount={!props.mobile ? props.nav() : undefined}>
185+
<DropdownMenu.Portal>
186186
<DropdownMenu.Content
187187
onCloseAutoFocus={(event) => {
188188
if (!props.pendingRename()) return

0 commit comments

Comments
 (0)