Ensure we do things correctly in finish effect handoff

JoviDeCroock · JoviDeCroock · commit 217f16d21703 · 2025-11-12T20:10:28.000+01:00
diff --git a/packages/react/runtime/src/index.ts b/packages/react/runtime/src/index.ts
@@ -123,7 +123,7 @@ function finishComponentEffect(
 	prevStore: EffectStore | undefined,
 	endEffect: () => void
 ) {
-	Signal.prototype._subscribe = this._sub;
+	Signal.prototype._subscribe = prevStore ? prevStore._sub : realSubscribe;
 	endEffect();
 	currentStore = prevStore;
 }

Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,7 @@ function finishComponentEffect(`
`123`	`123`	`prevStore: EffectStore \| undefined,`
`124`	`124`	`endEffect: () => void`
`125`	`125`	`) {`
`126`		`- Signal.prototype._subscribe = this._sub;`
	`126`	`+ Signal.prototype._subscribe = prevStore ? prevStore._sub : realSubscribe;`
`127`	`127`	`endEffect();`
`128`	`128`	`currentStore = prevStore;`
`129`	`129`	`}`