Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions for SKAdNetwork endImpression call #1029

Open
jsrofrimfram opened this issue Jul 19, 2024 · 1 comment
Open

Questions for SKAdNetwork endImpression call #1029

jsrofrimfram opened this issue Jul 19, 2024 · 1 comment

Comments

@jsrofrimfram
Copy link

Hello,

According to this line of code here, SKAdNetwork endImpression is being called 5 seconds after startImpression call. According to Apple documentation, endImpression is to be called when the ad is no longer visible to the user. Can this implementation lead to loss of actual duration of ad visibility in reports (endImpression time - startImpression time) ?

SKAdNetwork.endImpression(self.imp, completionHandler: { error in

@jsligh
Copy link
Collaborator

jsligh commented Jul 23, 2024

@jsrofrimfram It is coded this way because of the situation in which if there are multiple impressions and endImpression isn't called, a new impression overrides it. Apple's documentation on the subject does seem a bit confusing when looking at https://developer.apple.com/documentation/storekit/skadnetwork/3727304-startimpression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triage
Development

No branches or pull requests

2 participants