Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to Swift #396

Closed
YuriyVelichkoOpenX opened this issue Jul 9, 2021 · 2 comments
Closed

Migration to Swift #396

YuriyVelichkoOpenX opened this issue Jul 9, 2021 · 2 comments

Comments

@YuriyVelichkoOpenX
Copy link
Contributor

Motivation

The public classes of the Rendering Module were migrated from Objective-C to Swift. All others are on Objective-C still.

Swift Package Manager does not support mixed frameworks. Therefore we can't provide Prebbid Mobile with rendering through SPM.

We could split Objective-C and Swift parts to introduce different modules, but it controversies our modularization strategy (#395) in part dedicated to following the principles of layered architecture. So it is better to concentrate efforts on the complete migration.

Given

In the following doc, you can find the list of classes for migration

https://docs.google.com/spreadsheets/d/1ZZoRkXsIa95RZELCoEsP4IHJ5TDyRsNAlfKSQU2YohI/edit?usp=sharing

Objective

Feel free to take any Objective-C class, mark the row in the doc with yellow color, and migrate it to Swift.

Try to follow the priority column. It will help to take the less coupled classes first.

Mark migrated classes green after migration.

@YuriyVelichkoPI
Copy link
Contributor

The implementation of this epic will fix SPM integration

@jsligh
Copy link
Collaborator

jsligh commented May 31, 2024

#961 should solve this issue.

@jsligh jsligh closed this as completed May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants