Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL double encoding issue #901

Closed
OlenaPostindustria opened this issue Aug 14, 2023 · 0 comments · Fixed by #902
Closed

URL double encoding issue #901

OlenaPostindustria opened this issue Aug 14, 2023 · 0 comments · Fixed by #902
Assignees
Milestone

Comments

@OlenaPostindustria
Copy link
Collaborator

Objectives

The PrebidMobile SDK encodes URLs, which have been already encoded.

We can handle this issue in the following way:

  1. Try to create an URL as is without encoding.
  2. If the URL is created without errors - just use it
  3. IF the URL is not created due to the error - try to encode it

Precondition - all macros should be resolved before converting the string to the URL.

It would be great if we apply this approach to all places in the SDK where we encode the URL's string now.

Originally posted by @YuriyVelichkoPI in #896 (comment)

@OlenaPostindustria OlenaPostindustria self-assigned this Aug 14, 2023
@OlenaPostindustria OlenaPostindustria changed the title Double URL encoding issue URL double encoding issue Aug 14, 2023
@OlenaPostindustria OlenaPostindustria added this to the 2.1.3 milestone Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant