Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building for Node v12.18 produces wrong ABI version #43

Closed
kriszyp opened this issue Sep 11, 2020 · 2 comments
Closed

Building for Node v12.18 produces wrong ABI version #43

kriszyp opened this issue Sep 11, 2020 · 2 comments

Comments

@kriszyp
Copy link
Contributor

kriszyp commented Sep 11, 2020

If I prebuildify with Node v12 as a target:

prebuildify --target 12.18.0

It seems to properly build the right binary, but it saves the file as node.abi68.node, which is not the correct ABI version, the correct ABI version for Node v12.18 is 72 (https://nodejs.org/en/download/releases/), so when user attempts to run the module in Node v12, it says there is no native build available (or builds/compiles as a fallback during installation).

This seems to be the case for any platform I specify.

@kriszyp
Copy link
Contributor Author

kriszyp commented Sep 11, 2020

I guess this is actually due to electron/node-abi#90

@ludiazv
Copy link

ludiazv commented Oct 1, 2020

This also affects node 13 & 14.
There is a PR on node-abi to solve but still not merged or published. electron/node-abi#95 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants