Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assumptions for direction of incoming/outcoming fields #42

Open
MakisH opened this issue Mar 19, 2025 · 2 comments
Open

Assumptions for direction of incoming/outcoming fields #42

MakisH opened this issue Mar 19, 2025 · 2 comments
Labels
schema Related to the adapter config schema

Comments

@MakisH
Copy link
Member

MakisH commented Mar 19, 2025

Some normal fields require assumptions for flipping their direction: for example, reading/writing a heat flux, or reading/writing a normal velocity (mainly interesting in 1D-3D flow coupling).

We need to ensure that adapters follow the same assumption. For example, that writing is outgoing, and reading is incoming (and does the flipping).

Alternatively, we could make the flipping a configuration option for the respective fields (related to #36 and the schema).

@precice-bot
Copy link

This issue has been mentioned on preCICE Forum on Discourse. There might be relevant details there:

https://precice.discourse.group/t/structure-structure-interaction-with-calculix/2298/2

@uekerman uekerman added the schema Related to the adapter config schema label Mar 24, 2025
@uekerman
Copy link
Member

We could also do both: Define a standard and make it configurable.

It also makes somehow sense to me that:

  • writing assumes an outward normal vector
  • reading assumes an inward normal vector

Side note: There is a mathematical convention that the normal vector is typically pointing outward. So writing would be as expected, where reading feels like flipping the sign.

Could look as follows

interfaces:
  - mesh_name: Fluid-Mesh
    write_data:
      - name: Force
      - normal-direction: outwards # the default for write data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
schema Related to the adapter config schema
Projects
None yet
Development

No branches or pull requests

3 participants