Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace mapjson with templates passed to jsonproc #1646

Open
Rangi42 opened this issue Mar 21, 2022 · 2 comments
Open

Replace mapjson with templates passed to jsonproc #1646

Rangi42 opened this issue Mar 21, 2022 · 2 comments

Comments

@Rangi42
Copy link
Member

Rangi42 commented Mar 21, 2022

tools/mapjson uses its own JSON parser (json11 instead of jsonproc's nlohmann/json), and hard-codes the details of the map-related files inside its C++ source. This is difficult to edit without knowing C++. It seems to me that the map-related files, like data/layouts/layouts.inc, could be generated the same way as wild data, with tools/jsonproc.
@rawr51919
Copy link
Contributor

Might be able to make the whole generation process more repo-agnostic that way too

@rawr51919
Copy link
Contributor

Also something to note: Would this in turn fix #1261?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rawr51919 @Rangi42