You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems the code doesn't try to drop PII from lists of structs. e.g. additional_drivers is missed out here:
def drop_pii(%MODULE{} = value) do
value = Map.from_struct(value)
value = Map.update!(value, :proposer, &MODULE.drop_pii_proposer/1)
value = Map.update!(value, :vehicle, &MODULE.drop_pii_vehicle/1)
value = Map.update!(value, :cover, &MODULE.drop_pii_cover/1)
value = Map.update!(value, :meta, &MODULE.drop_pii_meta/1)
Kernel.struct(MODULE, value)
end
But in the example above, the proposer's PII is also present...
Traces on the PII-less bucket now have PII in them:
example: s3://prima-uk-pricing-engine-production/traces/version=v3/year=2023/month=06/day=25/lineage_id=6bbe07ac-0fae-4a23-8029-8d13fb2089ed/public-19ae69ec-0d5c-4a1c-9374-d7ecefb061f3.gz
It seems the code doesn't try to drop PII from lists of structs. e.g. additional_drivers is missed out here:
def drop_pii(%MODULE{} = value) do
value = Map.from_struct(value)
value = Map.update!(value, :proposer, &MODULE.drop_pii_proposer/1)
value = Map.update!(value, :vehicle, &MODULE.drop_pii_vehicle/1)
value = Map.update!(value, :cover, &MODULE.drop_pii_cover/1)
value = Map.update!(value, :meta, &MODULE.drop_pii_meta/1)
Kernel.struct(MODULE, value)
end
But in the example above, the proposer's PII is also present...
Related cards
The text was updated successfully, but these errors were encountered: