Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop_pii seems broken #17

Open
cpiemontese opened this issue Nov 18, 2024 · 0 comments
Open

drop_pii seems broken #17

cpiemontese opened this issue Nov 18, 2024 · 0 comments

Comments

@cpiemontese
Copy link

Traces on the PII-less bucket now have PII in them:

example: s3://prima-uk-pricing-engine-production/traces/version=v3/year=2023/month=06/day=25/lineage_id=6bbe07ac-0fae-4a23-8029-8d13fb2089ed/public-19ae69ec-0d5c-4a1c-9374-d7ecefb061f3.gz

It seems the code doesn't try to drop PII from lists of structs. e.g. additional_drivers is missed out here:

def drop_pii(%MODULE{} = value) do
value = Map.from_struct(value)
value = Map.update!(value, :proposer, &MODULE.drop_pii_proposer/1)
value = Map.update!(value, :vehicle, &MODULE.drop_pii_vehicle/1)
value = Map.update!(value, :cover, &MODULE.drop_pii_cover/1)
value = Map.update!(value, :meta, &MODULE.drop_pii_meta/1)
Kernel.struct(MODULE, value)
end

But in the example above, the proposer's PII is also present...

Related cards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant