Skip to content

Commit

Permalink
fix: stylelint rule disables
Browse files Browse the repository at this point in the history
  • Loading branch information
francinelucca committed Jan 30, 2025
1 parent 0ae0893 commit 0a5a817
Show file tree
Hide file tree
Showing 11 changed files with 21 additions and 8 deletions.
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"@csstools/postcss-sass": "^5.1.1",
"@github/prettier-config": "^0.0.6",
"@primer/primitives": "^10.3.4",
"@primer/stylelint-config": "^13.2.2",
"@primer/stylelint-config": "^13.2.3",
"@primer/view-components": "^0.36.5",
"autoprefixer": "^10.4.18",
"chokidar-cli": "^3.0.0",
Expand Down
2 changes: 1 addition & 1 deletion src/base/kbd.scss
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
kbd {
display: inline-block;
padding: var(--base-size-4);
// stylelint-disable-next-line primer/typography
// stylelint-disable-next-line primer/typography, declaration-property-value-no-unknown
font: 11px $mono-font;
// stylelint-disable-next-line primer/typography
line-height: 10px;
Expand Down
2 changes: 1 addition & 1 deletion src/branch-name/branch-name.scss
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
display: inline-block;
// stylelint-disable-next-line primer/spacing
padding: 2px 6px;
// stylelint-disable-next-line primer/typography
// stylelint-disable-next-line primer/typography, declaration-property-value-no-unknown
font: 12px $mono-font;
color: var(--fgColor-muted, var(--color-fg-muted));
word-break: break-all;
Expand Down
12 changes: 12 additions & 0 deletions src/layout/grid.scss
Original file line number Diff line number Diff line change
@@ -1,16 +1,28 @@
// GRID

// Columns

// stylelint-disable-next-line declaration-property-value-no-unknown
.col-1 { width: (1 * 0.0833333333 * 100%); }
// stylelint-disable-next-line declaration-property-value-no-unknown
.col-2 { width: (2 * 0.0833333333 * 100%); }
// stylelint-disable-next-line declaration-property-value-no-unknown
.col-3 { width: (3 * 0.0833333333 * 100%); }
// stylelint-disable-next-line declaration-property-value-no-unknown
.col-4 { width: (4 * 0.0833333333 * 100%); }
// stylelint-disable-next-line declaration-property-value-no-unknown
.col-5 { width: (5 * 0.0833333333 * 100%); }
// stylelint-disable-next-line declaration-property-value-no-unknown
.col-6 { width: (6 * 0.0833333333 * 100%); }
// stylelint-disable-next-line declaration-property-value-no-unknown
.col-7 { width: (7 * 0.0833333333 * 100%); }
// stylelint-disable-next-line declaration-property-value-no-unknown
.col-8 { width: (8 * 0.0833333333 * 100%); }
// stylelint-disable-next-line declaration-property-value-no-unknown
.col-9 { width: (9 * 0.0833333333 * 100%); }
// stylelint-disable-next-line declaration-property-value-no-unknown
.col-10 { width: (10 * 0.0833333333 * 100%); }
// stylelint-disable-next-line declaration-property-value-no-unknown
.col-11 { width: (11 * 0.0833333333 * 100%); }
.col-12 { width: 100%; }

Expand Down
1 change: 0 additions & 1 deletion src/markdown/code.scss
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@
pre code,
pre tt {
display: inline;
max-width: auto;
padding: 0;
margin: 0;
overflow: visible;
Expand Down
2 changes: 1 addition & 1 deletion src/markdown/footnotes.scss
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
left: calc(var(--base-size-24) * -1);
pointer-events: none;
content: '';
// stylelint-disable-next-line primer/borders, primer/colors
// stylelint-disable-next-line primer/borders, primer/colors, declaration-property-value-no-unknown
border: 2px $border-style var(--borderColor-accent-emphasis, var(--color-accent-emphasis));
// stylelint-disable-next-line primer/borders
border-radius: $border-radius;
Expand Down
2 changes: 1 addition & 1 deletion src/markdown/markdown-body.scss
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
// stylelint-disable-next-line primer/spacing
padding: 0 1em;
color: var(--fgColor-muted, var(--color-fg-muted));
// stylelint-disable-next-line primer/borders, primer/colors
// stylelint-disable-next-line primer/borders, primer/colors, declaration-property-value-no-unknown
border-left: 0.25em $border-style var(--borderColor-default, var(--color-border-default));

> :first-child {
Expand Down
1 change: 1 addition & 0 deletions src/marketing/utilities/animations.scss
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// Animation utilities for marketing

.hover-grow-mktg {
// stylelint-disable-next-line declaration-property-value-no-unknown
transition: transform 0.4s $ease-mktg;

&:hover {
Expand Down
2 changes: 1 addition & 1 deletion src/navigation/sidenav.scss
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@

&:last-child {
// makes sure there is a "bottom border" in case the list is not long enough
// stylelint-disable-next-line primer/box-shadow
// stylelint-disable-next-line primer/box-shadow, declaration-property-value-no-unknown
box-shadow: 0 $border-width 0 var(--borderColor-default, var(--color-border-default));
}

Expand Down
1 change: 1 addition & 0 deletions src/utilities/typography.scss
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,7 @@

/* Force long "words" to wrap if they exceed the width of the container */
.wb-break-word {
// stylelint-disable-next-line declaration-property-value-keyword-no-deprecated
word-break: break-word !important;
// this is for backwards compatibility with browsers that don't respect overflow-wrap
word-wrap: break-word !important;
Expand Down

0 comments on commit 0a5a817

Please sign in to comment.