Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not exactly the same #111

Open
func0x opened this issue Jan 20, 2021 · 3 comments
Open

Not exactly the same #111

func0x opened this issue Jan 20, 2021 · 3 comments
Labels
type: syntax Syntax highlighting

Comments

@func0x
Copy link

func0x commented Jan 20, 2021

HI I wait long time to this new version. Thank you for your work ❤️
But i check it and this not match exactly.
Up is site and down is vscode.
Zrzut ekranu 2021-01-20 o 23 15 14
@simurai
Copy link
Contributor

simurai commented Jan 22, 2021

VS Code and github.com use different libraries for the syntax highlighting, so we'll have to see how close we can make them match.

Mind linking to the above code? 🙇 Just in case it's public, of course.

@func0x
Copy link
Author

func0x commented Jan 22, 2021

Off course. This is a link https://github.com/leerob/mastering-nextjs/blob/master/course/react/02-props/functional.js

@simurai simurai added the type: syntax Syntax highlighting label Jan 6, 2023
archseer added a commit to helix-editor/helix that referenced this issue Jan 19, 2023
@archseer
theme: Make github match github.com more closely
efeec12 
This is a slight divergence from the VSCode theme, but it's more
accurate.

primer/github-vscode-theme#111
primer/github-vscode-theme#88
kirawi pushed a commit to kirawi/helix that referenced this issue Jan 25, 2023
@archseer
theme: Make github match github.com more closely
b9441eb 
This is a slight divergence from the VSCode theme, but it's more
accurate.

primer/github-vscode-theme#111
primer/github-vscode-theme#88
@kadeeraziz
Copy link

I have the same issue as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: syntax Syntax highlighting
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@simurai @func0x @kadeeraziz