Types and parameters in GitHub Light are darker orange

[jeffgennari]

It seems that GitHub Light Default has changed the orange color to be darker for types and parameters. See the following "Promise" type as an example:

github-vscode-theme/src/index.js

Line 35 in a00f340

.then(() => Promise.all([

Should the theme be updated to match?

[aminsamad]

Add to settings.json

"editor.semanticHighlighting.enabled": false

[jeffgennari]

That will just disable semantic highlighting, not address the color itself. Perhaps the textmate scope needs to be changed?

Changing meta.definition.variable and variable.parameter.function to use primer light variable orange 8 or 9 seems to match the GitHub website better.