From c3c60f0c839786ebff98e0bf5da48d2a1fabdb51 Mon Sep 17 00:00:00 2001 From: Henriette Darge Date: Tue, 12 Mar 2024 09:03:00 +0100 Subject: [PATCH] Prevent rounded corners in the middle of a BorderBox --- .changeset/proud-pens-dress.md | 5 +++++ app/components/primer/beta/border_box.pcss | 5 ++--- 2 files changed, 7 insertions(+), 3 deletions(-) create mode 100644 .changeset/proud-pens-dress.md diff --git a/.changeset/proud-pens-dress.md b/.changeset/proud-pens-dress.md new file mode 100644 index 0000000000..6a7d21e520 --- /dev/null +++ b/.changeset/proud-pens-dress.md @@ -0,0 +1,5 @@ +--- +"@primer/view-components": patch +--- + +Prevent rounded corners in the middle of a Primer::Beta::BorderBox diff --git a/app/components/primer/beta/border_box.pcss b/app/components/primer/beta/border_box.pcss index 9beb7f33f4..08ac55a307 100644 --- a/app/components/primer/beta/border_box.pcss +++ b/app/components/primer/beta/border_box.pcss @@ -89,7 +89,7 @@ border-bottom: var(--borderWidth-thin) solid var(--borderColor-default); /* Ensures bottom-border doesn't poke out when .Box-body used without box-footer */ - &:last-of-type { + &:last-child { margin-bottom: calc(var(--borderWidth-thin) * -1); border-bottom-right-radius: var(--borderRadius-medium); border-bottom-left-radius: var(--borderRadius-medium); @@ -106,8 +106,7 @@ border-top-width: var(--borderWidth-thin); &:first-of-type { - border-top-left-radius: var(--borderRadius-medium); - border-top-right-radius: var(--borderRadius-medium); + border-top-width: 0; } &:last-of-type {