Skip to content

Commit 07cecca

Browse files
committed
Use common fork
1 parent 4652de5 commit 07cecca

File tree

3 files changed

+26
-114
lines changed

3 files changed

+26
-114
lines changed

.github/workflows/e2e_tests.yaml

Lines changed: 21 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,14 +55,15 @@ jobs:
5555
- name: Checkout common repo code
5656
uses: actions/checkout@v4
5757
with:
58-
repository: 'project-codeflare/codeflare-common'
59-
ref: 'main'
58+
repository: 'sutaakar/codeflare-common'
59+
ref: 'kind'
6060
path: 'common'
6161

6262
- name: Checkout CodeFlare operator repository
6363
uses: actions/checkout@v4
6464
with:
65-
repository: project-codeflare/codeflare-operator
65+
repository: sutaakar/codeflare-operator
66+
ref: 'kind'
6667
path: codeflare-operator
6768

6869
- name: Set Go
@@ -75,6 +76,12 @@ jobs:
7576
with:
7677
token: ${{ secrets.GITHUB_TOKEN }}
7778

79+
- name: Set up specific Python version
80+
uses: actions/setup-python@v5
81+
with:
82+
python-version: '3.9'
83+
cache: 'pip' # caching pip dependencies
84+
7885
- name: Setup and start KinD cluster
7986
uses: ./common/github-actions/kind
8087

@@ -113,6 +120,8 @@ jobs:
113120
kubectl create clusterrolebinding sdk-user-clusterqueue-creator --clusterrole=clusterqueue-creator --user=sdk-user
114121
kubectl create clusterrole localqueue-creator --verb=get,list,create,delete,patch --resource=localqueues
115122
kubectl create clusterrolebinding sdk-user-localqueue-creator --clusterrole=localqueue-creator --user=sdk-user
123+
kubectl create clusterrole list-secrets --verb=get,list --resource=secrets
124+
kubectl create clusterrolebinding sdk-user-list-secrets --clusterrole=list-secrets --user=sdk-user
116125
kubectl config use-context sdk-user
117126
118127
- name: Run e2e tests
@@ -125,11 +134,20 @@ jobs:
125134
poetry install --with test,docs
126135
echo "Running e2e tests..."
127136
poetry run pytest -v -s ./tests/e2e -m kind > ${CODEFLARE_TEST_OUTPUT_DIR}/pytest_output.log 2>&1
137+
env:
138+
GRPC_DNS_RESOLVER: "native"
128139

129140
- name: Switch to kind-cluster context to print logs
130141
if: always() && steps.deploy.outcome == 'success'
131142
run: kubectl config use-context kind-cluster
132143

144+
- name: Print all
145+
if: always()
146+
run: |
147+
kubectl get Ingress -A -o yaml
148+
echo "******************"
149+
kubectl get pods -n ingress-nginx -o yaml
150+
133151
- name: Print CodeFlare operator logs
134152
if: always() && steps.deploy.outcome == 'success'
135153
run: |

tests/e2e/local_interactive_sdk_kind_test.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from codeflare_sdk import Cluster, ClusterConfiguration, TokenAuthentication
1+
from codeflare_sdk import Cluster, ClusterConfiguration, TokenAuthentication, generate_cert
22

33
import pytest
44
import ray
@@ -12,15 +12,11 @@ class TestRayLocalInteractiveOauth:
1212
def setup_method(self):
1313
initialize_kubernetes_client(self)
1414

15-
def teardown_method(self):
16-
delete_namespace(self)
17-
1815
def test_local_interactives(self):
1916
self.setup_method()
2017
create_namespace(self)
2118
create_kueue_resources(self)
2219
self.run_local_interactives()
23-
self.teardown_method()
2420

2521
def run_local_interactives(self):
2622
ray_image = get_ray_image()
@@ -47,6 +43,10 @@ def run_local_interactives(self):
4743
cluster.up()
4844
cluster.wait_ready()
4945

46+
generate_cert.generate_tls_cert(cluster_name, self.namespace)
47+
generate_cert.export_env(cluster_name, self.namespace)
48+
49+
print(cluster.local_client_url())
5050
ray.shutdown()
5151
ray.init(address=cluster.local_client_url(), logging_level="DEBUG")
5252

tests/e2e/mnist_raycluster_sdk_kind_test.py

Lines changed: 0 additions & 106 deletions
This file was deleted.

0 commit comments

Comments
 (0)