Skip to content

Fix for UI not coming when page reloaded with camera app open #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JeevakaPrabu wants to merge 1 commit into
base: r/ics3a/main
Choose a base branch
from
Open

Fix for UI not coming when page reloaded with camera app open #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/ClientCommunicator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,13 +231,14 @@ void ClientCommunicator::handleCameraInfo(uint32_t header_size) {
&& (mCameraSessionState != CameraSessionState::kDecodingStarted)) {
gVirtualCameraFactory.createVirtualRemoteCamera(mVideoDecoder, mClientId,
camera_info[i]);
} else {
} else {
ALOGE("%s(%d): Camera is already in opened or decoding state,"
"avoiding adding entry for other camera", __FUNCTION__, mClientId);
}
}
mValidClientCapInfo = IsValidClientCapInfo;
}
sendAck();
}


Expand Down Expand Up @@ -340,7 +341,7 @@ bool ClientCommunicator::clientThread() {
MSG_WAITALL)) > 0) {
ALOGVV("%s(%d): Received Header %zd bytes. Payload size: %u",
__FUNCTION__, mClientId, size, header.size);
switch (header.type) {
switch (header.type) {
case REQUEST_CAPABILITY:
if(header.size != 0) {
ALOGE("%s(%d): Invalid header size for REQ_CAP packet",
Expand All @@ -352,11 +353,11 @@ bool ClientCommunicator::clientThread() {
if ((mCameraSessionState != CameraSessionState::kCameraOpened)
&& (mCameraSessionState != CameraSessionState::kDecodingStarted)) {
gVirtualCameraFactory.clearCameraInfo(mClientId);
sendCameraCapabilities();
} else {
} else {
ALOGE("%s(%d): Camera is in opened or decoding state,"
"avoid clearing the cameras", __FUNCTION__, mClientId);
}
sendCameraCapabilities();
break;
case CAMERA_INFO:
mValidClientCapInfo = false;
Expand All @@ -370,10 +371,9 @@ bool ClientCommunicator::clientThread() {
ALOGE("%s(%d): header size exceeds the max limit, size = %u",
__FUNCTION__, mClientId, header.size);
} else {
mNumOfCamerasRequested = (header.size) / sizeof(camera_info_t);
mNumOfCamerasRequested = (header.size) / sizeof(camera_info_t);
handleCameraInfo(header.size);
}
sendAck();
break;
case CAMERA_DATA:
if (!mIsConfigurationDone) {
Expand All @@ -394,7 +394,7 @@ bool ClientCommunicator::clientThread() {
ALOGE("%s(%d): invalid camera_packet_type: %s", __FUNCTION__, mClientId,
camera_type_to_str(header.type));
break;
}
}
continue;
}
} else {
Expand Down