Contact List Project#18
Open
jacobecox wants to merge 11 commits into
Open
Conversation
added 11 commits
July 3, 2024 08:38
| import { useParams } from 'next/navigation'; | ||
| import { contactData } from 'app/data/contactData'; | ||
|
|
||
| export default function Player() { |
There was a problem hiding this comment.
why is this component named player?
also the file is page.js
Comment on lines
+36
to
+40
|
|
||
| <button className='back-button' onClick={handleClick}>Back</button> | ||
| </div> | ||
| </main> | ||
| ); |
Comment on lines
+19
to
+28
| all: function () { | ||
| return this.contacts; | ||
| }, | ||
| addContact: function ({ id, photo, name, email, number }) { | ||
| this.contacts.push({ id, photo, name, email, number }); | ||
| }, | ||
| get: function (id) { | ||
| const isContact = (c) => c.id === id; | ||
| return this.contacts.find(isContact); | ||
| }, |
There was a problem hiding this comment.
your alignment makes it very hard to read the code
| this.contacts.push({ id, photo, name, email, number }); | ||
| }, | ||
| get: function (id) { | ||
| const isContact = (c) => c.id === id; |
There was a problem hiding this comment.
dont use letters to abbreviate, this makes the code harder to understand, also what does it mean isContact?
Suggested change
| const isContact = (c) => c.id === id; | |
| const isContact = contact => contact.id === id; |
| const [email, setEmail] = useState(null); | ||
| const router = useRouter(); | ||
|
|
||
| NewContact.propTypes = { |
There was a problem hiding this comment.
define your proptypes outside of your class!!
Comment on lines
+38
to
+41
| }) | ||
|
|
||
| router.push('/'); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.