Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Country Selector #28

Open
philsturgeon opened this issue Apr 3, 2020 · 7 comments
Open

Country Selector #28

philsturgeon opened this issue Apr 3, 2020 · 7 comments
Assignees

Comments

@philsturgeon
Copy link
Collaborator

philsturgeon commented Apr 3, 2020

The goal of the selector is to help elevator relevant content to you, so somebody in Serbia should be able to see any content which is in Serbia, as well as globally available content.

Country selection for now will have nothing to do with translations or localization, we'll deal with that in #14 later.

A selector like this would be awesome:

image

All categories should be available to people, even if there are no suggestions in that category.

All tags should be available to people, even if there are no suggestions in that tag.

We could show a message like "There are currently no available actions in your country, but click here to see some more ideas." and it expands a global list, We don't want people to be unable to find things, we just want it to be relevant to them if possible.

@philsturgeon philsturgeon added this to the May v2.0 Launch milestone Apr 3, 2020
@philsturgeon philsturgeon changed the title v2 Country Selector Country Selector Apr 6, 2020
@Squallac
Copy link

Squallac commented Apr 8, 2020

I'll work on this

@philsturgeon
Copy link
Collaborator Author

@Squallac excellent, thank you.

@Squallac
Copy link

@philsturgeon Do we have a specific list of countries that you want to show? Or I'll just list all of them

@philsturgeon
Copy link
Collaborator Author

All the ones we have content for. It can be done manually, but bonus points if it can be automated.

@philsturgeon
Copy link
Collaborator Author

philsturgeon commented Sep 2, 2020

I took a swing at fixing the country selector in v1 (b0314ab) because v2 stalled out, but I cannot seem to get the selection to persist between page loads because I do not understand React context. If anyone can get it working in main real quick then we can have this handy feature alive until v2 comes along.

To try it out, uncomment the selector in the footer, and refresh after selecting. Currently the country you selected will vanish on refresh or clicking to another page.

If you get persistence working, when you go to a category you should only see links for the country or global content.

@piperchester
Copy link
Contributor

I took a swing at fixing the country selector in v1 (b0314ab) because v2 stalled out, but I cannot seem to get the selection to persist between page loads because I do not understand React context. If anyone can get it working in main real quick then we can have this handy feature alive until v2 comes along.

To try it out, uncomment the selector in the footer, and refresh after selecting. Currently the country you selected will vanish on refresh or clicking to another page.

If you get persistence working, when you go to a category you should only see links for the country or global content.

I'll start exploring this. Was considering persisting some state in session storage or a cookie, if no one has any objections.

@philsturgeon
Copy link
Collaborator Author

philsturgeon commented Oct 20, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants