Skip to content

Commit 260cf53

Browse files
committed
- Small updates to dbpa_remote_testapp for consistency on data page generation params.
1 parent 052760f commit 260cf53

File tree

1 file changed

+11
-12
lines changed

1 file changed

+11
-12
lines changed

src/scripts/dbpa_remote_testapp.cpp

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -451,17 +451,17 @@ class DBPARemoteTestApp {
451451
std::cout << "Binary size: " << float_binary_data.size() << " bytes" << std::endl;
452452

453453
// Build DATA_PAGE_V2 payload: level bytes (uncompressed) + compressed value bytes
454-
const int32_t def_len = 2;
455-
const int32_t rep_len = 1;
456-
std::vector<uint8_t> level_bytes(static_cast<size_t>(def_len + rep_len), 0x00);
454+
const int32_t def_len = 3;
455+
const int32_t rep_len = 5;
456+
std::vector<uint8_t> level_bytes(static_cast<size_t>(def_len + rep_len), 0xCC);
457457
auto compressed_values = Compress(float_binary_data, CompressionCodec::SNAPPY);
458458
auto joined_plaintext = Join(level_bytes, compressed_values);
459459

460460
std::map<std::string, std::string> float_encoding_attributes = {
461461
{"page_type", "DATA_PAGE_V2"},
462462
{"data_page_num_values", std::to_string(float_test_data.size())},
463463
{"data_page_max_definition_level", "1"},
464-
{"data_page_max_repetition_level", "0"},
464+
{"data_page_max_repetition_level", "2"},
465465
{"page_v2_definition_levels_byte_length", std::to_string(def_len)},
466466
{"page_v2_repetition_levels_byte_length", std::to_string(rep_len)},
467467
{"page_v2_num_nulls", "0"},
@@ -620,19 +620,18 @@ class DBPARemoteTestApp {
620620

621621
// Build DATA_PAGE_V1 payload: level bytes use RLE blocks with length prefixes
622622
std::vector<uint8_t> level_bytes;
623-
append_u32_le(level_bytes, 1); // repetition level block length
624-
level_bytes.push_back(0xAA);
625-
append_u32_le(level_bytes, 2); // definition level block length
626-
level_bytes.push_back(0xBB);
627-
level_bytes.push_back(0xCC);
623+
append_u32_le(level_bytes, 3); // repetition level block length
624+
level_bytes.insert(level_bytes.end(), 3, 0xAA);
625+
append_u32_le(level_bytes, 5); // definition level block length
626+
level_bytes.insert(level_bytes.end(), 5, 0xBB);
628627
auto combined_uncompressed = Join(level_bytes, fixed_length_data);
629628
auto joined_plaintext = Compress(combined_uncompressed, CompressionCodec::SNAPPY);
630629
std::cout << "Compressed size: " << joined_plaintext.size() << " bytes" << std::endl;
631630
std::map<std::string, std::string> fixed_len_encoding_attributes = {
632631
{"page_type", "DATA_PAGE_V1"},
633-
{"data_page_num_values", "3"},
634-
{"data_page_max_repetition_level", "1"},
632+
{"data_page_num_values", std::to_string(std::size(test_strings))},
635633
{"data_page_max_definition_level", "1"},
634+
{"data_page_max_repetition_level", "2"},
636635
{"page_v1_repetition_level_encoding", "RLE"},
637636
{"page_v1_definition_level_encoding", "RLE"},
638637
{"page_encoding", "PLAIN"}
@@ -718,7 +717,7 @@ class DBPARemoteTestApp {
718717
decompressed_combined.begin() + static_cast<std::ptrdiff_t>(offset + def_len));
719718
offset += def_len;
720719

721-
if (rep_bytes != std::vector<uint8_t>{0xAA} || def_bytes != std::vector<uint8_t>{0xBB, 0xCC}) {
720+
if (rep_bytes != std::vector<uint8_t>{0xAA, 0xAA, 0xAA} || def_bytes != std::vector<uint8_t>{0xBB, 0xBB, 0xBB, 0xBB, 0xBB}) {
722721
std::cout << "ERROR: Level bytes content mismatch" << std::endl;
723722
return false;
724723
}

0 commit comments

Comments
 (0)