Updating to the latest version of DBPA, where 'Undefined' was removed.#236
Updating to the latest version of DBPA, where 'Undefined' was removed.#236argmarco-tkd merged 1 commit intomainfrom
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
| #TODO: Change to a specific tag/commit when we have one. | ||
| #https://github.com/protegrity/arrow/issues/179 | ||
| GIT_TAG 4c808b2233ed0bc04529c3b0dbf7c214c4901043 | ||
| GIT_TAG 6206fb0e27556a0df9160364caa3819e4af3fe0f |
There was a problem hiding this comment.
As a reference, can we add an inline comment to what PR is this aligned with?
There was a problem hiding this comment.
not sure about this. A PR link may not give the full picture of the code that is being referenced. Let me know your thoughts.
There was a problem hiding this comment.
You're right. It's ok to leave as-is. Thanks.
| {parquet::Type::BYTE_ARRAY, dbps::external::Type::BYTE_ARRAY}, | ||
| {parquet::Type::FIXED_LEN_BYTE_ARRAY, dbps::external::Type::FIXED_LEN_BYTE_ARRAY}, | ||
| {parquet::Type::UNDEFINED, dbps::external::Type::UNDEFINED}}; | ||
| {parquet::Type::FIXED_LEN_BYTE_ARRAY, dbps::external::Type::FIXED_LEN_BYTE_ARRAY}}; |
There was a problem hiding this comment.
I would add an inline comment to say why UNDEFINED can be excluded. Basically what we talked about, but to keep for future reference.
avalerio-tkd
left a comment
avalerio-tkd
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the change.
…s removed from 'enums.h'
argmarco-tkd
force-pushed
the
update_dbpa_interface
branch
from
9470fe9 to
94c6a82
Compare
|
fyi, this broke the linter github action again. Thanks! |
3 participants
Updating to the latest version of DBPA library - where 'UNDEFINED' was removed from 'enums.h'
Testing
ctest -L parquet)base_app.py)