Fixing Windows failing github actions#242
Merged
sofia-tekdatum merged 9 commits intomainfrom Feb 5, 2026
Merged
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
sofia-tekdatum
changed the title
argmarco-tkd
reviewed
Feb 4, 2026
| * - parquet::Type and dbps::external::Type | ||
| * - arrow::Compression and dbps::external::CompressionCodec | ||
| */ | ||
| class DBPAEnumUtils { |
Collaborator
There was a problem hiding this comment.
why is this needed (for my own education)
Collaborator
Author
There was a problem hiding this comment.
Unity is used in Windows for linking, and unless the classes and methods are tagged with PARQUET_EXPORT, they are not visible at linkage time.
argmarco-tkd
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing Windows actions that fail due to Boost and/or Crow mismatch issues.
AMD64 Windows MinGW 64 GLib & Ruby
Before
After
AMD64 Windows MinGW MINGW64 C++
Before
After
Now failing because of s3 bucket voltron-labs-datasets not found.
AMD64 Windows MSVC GLib
Before
After
AMD64 Windows 2022 AVX2
Before
After
Now failing because of unrelated errors.