We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ns.remove(node)
protobuf.js version: 7.3.2 and newer.
Steps to reproduce:
Type
const myType = ns.lookupType('.MyType')
myType.name = "NewName"
myType.parent.remove(myType)
Expected:
nestedArray
Actual:
I've added a test in a fork: runeh@a04e6ea
I assume it's due to this line:
protobuf.js/src/namespace.js
Line 261 in 59569c1
The remove code assumes that the name will not have changed between the node being added and removed.
remove
The text was updated successfully, but these errors were encountered:
No branches or pull requests
protobuf.js version: 7.3.2 and newer.
Steps to reproduce:
Type
object in the tree:const myType = ns.lookupType('.MyType')
myType.name = "NewName"
myType.parent.remove(myType)
Expected:
nestedArray
propertyActual:
I've added a test in a fork: runeh@a04e6ea
I assume it's due to this line:
protobuf.js/src/namespace.js
Line 261 in 59569c1
The
remove
code assumes that the name will not have changed between the node being added and removed.The text was updated successfully, but these errors were encountered: