Skip to content

Commit fcca609

Browse files
pveperf: print errno on die if sensible
Signed-off-by: Thomas Lamprecht <[email protected]>
1 parent 259c05e commit fcca609

File tree

1 file changed

+5
-10
lines changed

1 file changed

+5
-10
lines changed

bin/pveperf

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ if ($#ARGV >= 1) {
1616
my $path = $ARGV[0] || '/';
1717

1818
sub drop_cache {
19-
2019
# free pagecache,dentries,inode cache
2120
if (-f '/proc/sys/vm/drop_caches') {
2221
system ("echo 3 > /proc/sys/vm/drop_caches");
@@ -67,7 +66,6 @@ sub test_fsync {
6766
my $dir = "$basedir/ptest.$$";
6867

6968
eval {
70-
7169
mkdir $dir;
7270

7371
my $data = ('A' x 4000) . "\n";
@@ -82,7 +80,7 @@ sub test_fsync {
8280

8381
my $filename = "$dir/tf_$m.dat";
8482

85-
open (TMP, ">$filename") || die "open failed";
83+
open (TMP, ">$filename") || die "open failed: $!\n";
8684

8785
print TMP $data;
8886

@@ -111,7 +109,7 @@ sub test_seektime {
111109

112110
drop_cache ();
113111

114-
open (ROOTHD, "<$rootdev") || die "unable to open HD";
112+
open (ROOTHD, "<$rootdev") || die "unable to open HD '$rootdev': $!\n";
115113

116114
my $starttime = [gettimeofday];
117115
my $count;
@@ -124,7 +122,7 @@ sub test_seektime {
124122

125123
sysseek (ROOTHD, $pos, 0);
126124

127-
(sysread (ROOTHD, $readbuf, 512) == 512) || die "read failed";
125+
(sysread (ROOTHD, $readbuf, 512) == 512) || die "read failed: $!\n";
128126

129127
$elapsed = tv_interval ($starttime);
130128

@@ -149,18 +147,15 @@ sub test_read {
149147
my $readbuf;
150148

151149

152-
open (ROOTHD, "<$rootdev") || die "unable to open HD";
150+
open (ROOTHD, "<$rootdev") || die "unable to open HD '$rootdev': $!\n";
153151

154-
155152
for (;;) {
156-
157153
my $c = sysread (ROOTHD, $readbuf, 2 * 1024 *1024);
158-
die "read failed" if $c < 0;
154+
die "read failed: $!\n" if $c < 0;
159155

160156
$bytes += $c;
161157

162158
$elapsed = tv_interval ($starttime);
163-
164159
last if $elapsed > 3;
165160
}
166161

0 commit comments

Comments
 (0)